Programmability - prep for merge #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Lovejoy <[email protected]>
Signed-off-by: James Lovejoy <[email protected]> Co-authored-by: Gert-Jaap Glasbergen <[email protected]> Signed-off-by: James Lovejoy <[email protected]>
Signed-off-by: James Lovejoy <[email protected]>
Signed-off-by: James Lovejoy <[email protected]> Co-authored-by: Gert-Jaap Glasbergen <[email protected]> Signed-off-by: James Lovejoy <[email protected]>
Signed-off-by: James Lovejoy <[email protected]> Co-authored-by: Gert-Jaap Glasbergen <[email protected]> Signed-off-by: James Lovejoy <[email protected]>
Signed-off-by: James Lovejoy <[email protected]>
Signed-off-by: James Lovejoy <[email protected]> Co-authored-by: Gert-Jaap Glasbergen <[email protected]> Signed-off-by: James Lovejoy <[email protected]>
Signed-off-by: James Lovejoy <[email protected]>
Signed-off-by: James Lovejoy <[email protected]> Co-authored-by: Gert-Jaap Glasbergen <[email protected]> Signed-off-by: James Lovejoy <[email protected]>
Signed-off-by: James Lovejoy <[email protected]> Co-authored-by: Gert-Jaap Glasbergen <[email protected]> Signed-off-by: James Lovejoy <[email protected]>
Signed-off-by: James Lovejoy <[email protected]>
Signed-off-by: Gert-Jaap Glasbergen <[email protected]> Signed-off-by: James Lovejoy <[email protected]>
Signed-off-by: James Lovejoy <[email protected]>
Signed-off-by: James Lovejoy <[email protected]>
Signed-off-by: James Lovejoy <[email protected]>
Signed-off-by: James Lovejoy <[email protected]>
Signed-off-by: James Lovejoy <[email protected]>
maurermi
force-pushed
the
programmability
branch
2 times, most recently
from
38fa499
to
40c92fd
Compare
HalosGhost
reviewed
Apr 5, 2023
maurermi
force-pushed
the
programmability
branch
4 times, most recently
from
ce7e857
to
45f19cc
Compare
AlexRamRam
force-pushed
the
programmability
branch
3 times, most recently
from
b60d8e1
to
b51f20c
Compare
maurermi
reviewed
Apr 11, 2023
AlexRamRam
force-pushed
the
programmability
branch
2 times, most recently
from
c4d0fd0
to
e13f056
Compare
AlexRamRam
force-pushed
the
programmability
branch
from
f428583
to
708c78c
Compare
HalosGhost
reviewed
Jun 20, 2023
HalosGhost
reviewed
Jun 20, 2023
HalosGhost
reviewed
Jun 20, 2023
HalosGhost
reviewed
Jun 20, 2023
HalosGhost
reviewed
Jun 20, 2023
HalosGhost
reviewed
Jun 20, 2023
HalosGhost
reviewed
Jun 20, 2023
HalosGhost
reviewed
Jun 20, 2023
HalosGhost
reviewed
Jun 20, 2023
HalosGhost
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
I have a few very small style/typo nits, none of which are particularly high-priority.
Assuming the final bits of documentation follow all the same criteria current docs have gone through, that the renaming goes without a hitch (@maurermi and I chatted about strategy for this a bit offline, and I think there's a good plan in-place), and that the commits are squashed appropriately, I think this is set to merge. 👍
- Restructure primary README - Move Atomizer/2PC run the code section to a separate doc - Add programmability architecture writeup and diagrams - Add placeholder for user manual Signed-off-by: Alexander Jung <[email protected]>
Also document to clarify native value transfers in evm_host Fix #214 Signed-off-by: Alexander Jung <[email protected]>
Adds a sample ERC20 contract and deploy script to go along with the programmability user guide. Adds a script to run 3PC locally, and updates the 3pc docker-compose file to reflect OpenCBDC image naming convention. Signed-off-by: Michael Maurer <[email protected]>
Introduces a user guide for interacting with 3PC, based off a guide written by @wadagso-gertjaap. Update lint.sh to ignore .md files for trailing whitespace. Signed-off-by: Michael Maurer <[email protected]> Co-authored-by: Gert-Jaap Glasbergen <[email protected]>
…sactions Also: - Rename agent state code `function_error` -> `function_exception` to distinguish from `function_failed`. `function_exception` conveys an unexpected system error - `agent::impl::do_try_lock_request()` & `broker::impl::try_lock()` - clarify that false return value is returned only upon unexpected exceptions Fix #216 Signed-off-by: Alexander Jung <[email protected]>
Cleanup re [[fallthrough]] in switch statements (Fix #220) - src/3pc/agent/impl.cpp - src/3pc/broker/impl.cpp - src/uhs/twophase/coordinator/format.cpp src/3pc/agent/impl.cpp - do_commit(): remove unused code block in lambda callback passed to m_broker->commit() src/3pc/agent/runners/interface.hpp & src/3pc/agent/runners/lua/impl.hpp & src/3pc/agent/runners/evm/impl.hpp - runner::interface::run(): add [[nodiscard]] and comments src/3pc/agent/runners/evm/init_addresses.hpp - rename init_addresses → init_addresses_for_testing src/3pc/agent/runners/evm/serialization.hpp - fix broken doc comments src/3pc/directory/impl.cpp & src/3pc/directory/impl.hpp: - key_location(): note that using modulo operation creates a (very) small bias from a uniform distribution src/util/rpc/http/kqueue_event_handler.cpp - init(): fix if statement containing assignment tests/unit/3pc/agent/runners/evm/evm_test.cpp - Direct reader to origins of bytecode Signed-off-by: Alexander Jung <[email protected]> temp Signed-off-by: Alexander Jung <[email protected]>
Removes the large bytecode string for the Lua pay contract and generates bytecode at runtime. Now expects that the .lua file containing the contract code is provided as a config input in lua_bench. Makes similar change in account_test.cpp to generate bytecode at runtime. Moves location of and slightly modifies gen_bytecode.lua to better integrate within c++ source code. Signed-off-by: Michael Maurer <[email protected]>
Adds doc comments to evm_bench and tools/bench/3pc/evm/rpc_client. Also addresses lack of doc comments in host.hpp by pointing upstream. Signed-off-by: Michael Maurer <[email protected]>
maurermi
force-pushed
the
programmability
branch
from
9a123e4
to
287d00b
Compare
maurermi
approved these changes
Jun 21, 2023
In evm_host::create(), the evmc::result return object must have the create_address member set to the new contract address (the VM does not set it) If left as 0x0, deployment of contracts by another contract (i.e. at depth>0) is likely to fail such as in UniswapV3Factory.createPool() Signed-off-by: Alexander Jung <[email protected]>
Rename all instances of 3PC to PArSEC. Signed-off-by: Michael Maurer <[email protected]> Co-authored-by: Alexander Jung <[email protected]> Co-authored-by: Anders Brownworth <[email protected]>
Closed
HalosGhost
force-pushed
the
programmability
branch
2 times, most recently
from
c6d273e
to
6ed25e4
Compare
Signed-off-by: Sam Stuewe <[email protected]>
HalosGhost
force-pushed
the
programmability
branch
from
6ed25e4
to
c9a301c
Compare
|
Finalized reconciliation of rename, and updated docs. 👍 from me. Ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.