Skip to content

Commit

Permalink
Checked off some TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
mkranzlein committed Aug 22, 2023
1 parent 0b35e81 commit bd4e4ee
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,8 @@ def some_function(x: Float[torch.Tensor, "10, 768"]):
I recommend taking a look at the [jaxtyping docs](https://docs.kidger.site/jaxtyping/).

## TODOs
- Eval needs to account for wordpiece splits
- Some long documents are too big for GPU vram right now
- Batching right now should allow for single documents, but worth testing
- Chunking logic could be more clear
- Last chunk of each doc might be improperly ignored?
- Eval needs final pieces put together and then needs to be tested
- Decide on consistent variables for type annotations
## Cite HiPool
Expand Down

0 comments on commit bd4e4ee

Please sign in to comment.