-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better naming for github action runs #175
base: dev
Are you sure you want to change the base?
Conversation
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Fix mlcommons#165, Replacement in the initial three files
@@ -10,6 +10,7 @@ on: | |||
|
|||
jobs: | |||
build: | |||
name: ${{ matrix.os }} - ${{ matrix.backend }} - ${{ matrix.implementation }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the line above should we replace "build" with something better? May be "rgat-inference-run" ?
test name update
@@ -10,7 +10,7 @@ on: | |||
|
|||
jobs: | |||
build: | |||
name: ${{ matrix.os }} - ${{ matrix.backend }} - ${{ matrix.implementation }} | |||
name: rgat-inference-run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sujik18 I was referring to the previous line where "build" is used. Do you know if the "name" field can override the job name "build"? If so, then it is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arjunsuresh Yes, I believe that by mentioning name field it will override the "build" as it did work for other tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you see the action here it still shows "build": https://github.com/mlcommons/mlperf-automations/actions/runs/13100736773
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arjunsuresh I tried replacing the build value with another job key value, but the test name is still showing as build. You can see it here https://github.com/mlcommons/mlperf-automations/actions/runs/13104065296/workflow
I double-checked for any syntax errors, but there aren't any. Even if it was a GitHub internal issue, it would have also affected other test names, but that isn't the case, so I'm not sure why it's happening.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sujik18 if the pull_request_target is specified in the github action, then the action is running from the base branch and so the PR changes won't be reflected there. But you can see for the changes in the github actions with "on:pull_request".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sujik18 the change is working fine 👍. Can you please revert back to pull_request_target - once the PR is merged, from next PR onwards the tests will run as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arjunsuresh I now understand that I was only checking the on:pull_request_target event. The recent commit was unnecessary. I will revert back to pull_request_target, and we can simply ignore the last commit to proceed with merging the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. The changes are fine for the github actions. Have you seen my comment on the logging part in the github issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, actually by mistake those commits got included with this PR instead of a new one, wrt to logger issue, apart from making the induvial script to utilize global logger, do we also need each script to write the logs in a single mlc-log.txt file,
I guess that would be a better approach for maintaining the logs?
Currently each script file is generating its own log.txt in its own directory. For that we need to change the default value given to the path for setup_logging function call, as the folder directory of mlc seems to have been changed, the current default value seems to be invalid.
Update job key value and name parameter
on pull request,command to reflect the changes
Fix for #134