-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better naming for github action runs #175
Open
sujik18
wants to merge
7
commits into
mlcommons:dev
Choose a base branch
from
sujik18:dev
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+24
−7
Open
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2ff9354
Better naming for github action runs
sujik18 8969942
Use mlc logger in scripts instead of print statements 1.0
sujik18 f3725f2
Update test-mlperf-inference-rgat.yml
sujik18 41c282f
Merge branch 'dev' into dev
arjunsuresh ca136ee
Merge branch 'dev' into dev
arjunsuresh 30c670c
Update test-mlperf-inference-rgat.yml
sujik18 7a61b8d
Update test-mlperf-inference-rgat.yml
sujik18 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sujik18 I was referring to the previous line where "build" is used. Do you know if the "name" field can override the job name "build"? If so, then it is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arjunsuresh Yes, I believe that by mentioning name field it will override the "build" as it did work for other tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you see the action here it still shows "build": https://github.com/mlcommons/mlperf-automations/actions/runs/13100736773
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arjunsuresh I tried replacing the build value with another job key value, but the test name is still showing as build. You can see it here https://github.com/mlcommons/mlperf-automations/actions/runs/13104065296/workflow
I double-checked for any syntax errors, but there aren't any. Even if it was a GitHub internal issue, it would have also affected other test names, but that isn't the case, so I'm not sure why it's happening.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sujik18 if the pull_request_target is specified in the github action, then the action is running from the base branch and so the PR changes won't be reflected there. But you can see for the changes in the github actions with "on:pull_request".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sujik18 the change is working fine 👍. Can you please revert back to pull_request_target - once the PR is merged, from next PR onwards the tests will run as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arjunsuresh I now understand that I was only checking the on:pull_request_target event. The recent commit was unnecessary. I will revert back to pull_request_target, and we can simply ignore the last commit to proceed with merging the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. The changes are fine for the github actions. Have you seen my comment on the logging part in the github issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, actually by mistake those commits got included with this PR instead of a new one, wrt to logger issue, apart from making the induvial script to utilize global logger, do we also need each script to write the logs in a single mlc-log.txt file,
I guess that would be a better approach for maintaining the logs?
Currently each script file is generating its own log.txt in its own directory. For that we need to change the default value given to the path for setup_logging function call, as the folder directory of mlc seems to have been changed, the current default value seems to be invalid.