🛡️ Sentinel: HIGH Fix path traversal in CustomEmployeeManager.SetPortrait

[mleem97]

🚨 Severity: HIGH
💡 Vulnerability: Path traversal vulnerability in SetPortrait method due to unsanitized employeeId parameter in Path.Combine.
🎯 Impact: Bypassing registration validation through direct method calls or deserialization could allow arbitrary file reading or existence checks outside the intended ModAssets directory, potentially exposing sensitive files.
🔧 Fix: Added independent validation using IndexOfAny(Path.GetInvalidFileNameChars()) >= 0 || Contains(".."). Wrapped the vulnerable operation in an if/else block rather than an early return to ensure that fallback UI colors are still applied correctly on invalid inputs.
✅ Verification: Tested against the test suite (dotnet test). Fallback logic remains reachable.

---

PR created automatically by Jules for task 7136690051448625121 started by @mleem97

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric	Results
Complexity	0
Duplication	0

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}