Add Windows-2025 to GitHub Actions OS Matrix #5710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billywr
force-pushed
the
update-win-version
branch
from
3dd5c3a to
a164b1f
Compare
billywr
force-pushed
the
update-win-version
branch
2 times, most recently
from
2af24a2 to
2efba31
Compare
iankingori
reviewed
Feb 10, 2025
.github/workflows/test-os.yml
Outdated
| @@ -165,6 +171,7 @@ jobs: | |||
| name: test-reports-${{ env.TEST_REPORT_NAME }} | |||
| path: ./bin/testreports | |||
| retention-days: 1 | |||
| overwrite: true | |||
There was a problem hiding this comment.
Instead of overwrite you could add OS to the report name and separate server 2022 and server 2025 artifacts
Signed-off-by: Billy Owire <[email protected]>
billywr
force-pushed
the
update-win-version
branch
from
2efba31 to
66d2deb
Compare
profnandaa
approved these changes
Feb 10, 2025
| @@ -162,7 +168,7 @@ jobs: | |||
| if: always() | |||
| uses: actions/upload-artifact@v4 | |||
| with: | |||
| name: test-reports-${{ env.TEST_REPORT_NAME }} | |||
| name: test-reports-${{ matrix.os }}-${{ env.TEST_REPORT_NAME }} | |||
There was a problem hiding this comment.
may be the matrix.os should come at the end of the name, but no strong preference.
|
Hmm. this is 47 minutes in longest job. We need to split this up (and also bench what is taking there so long) |
tonistiigi
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description:
PR updates the GitHub Actions workflow by expanding the OS matrix to include Windows 2025, ensuring broader compatibility and testing coverage.
Changes Introduced:
windows-2025to the OS matrix for test-windows-amd64.overwrite: trueto allow re-uploading the same artifact without failureTesting Steps: