Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows-2025 to GitHub Actions OS Matrix #5710

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Add Windows-2025 to GitHub Actions OS Matrix #5710

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/workflows/test-os.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ jobs:
retention-days: 1

test-windows-amd64:
runs-on: windows-2022
runs-on: ${{ matrix.os }}
needs:
- build
env:
Expand All @@ -79,6 +79,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [windows-2022, windows-2025]
worker:
- containerd
pkg:
Expand All @@ -89,7 +90,12 @@ jobs:
- ./frontend
- ./frontend/dockerfile
include:
-
- os: windows-2022
worker: containerd
pkg: ./...
skip-integration-tests: 1
- os: windows-2025
worker: containerd
pkg: ./...
skip-integration-tests: 1
steps:
Expand Down Expand Up @@ -162,7 +168,7 @@ jobs:
if: always()
uses: actions/upload-artifact@v4
with:
name: test-reports-${{ env.TEST_REPORT_NAME }}
name: test-reports-${{ matrix.os }}-${{ env.TEST_REPORT_NAME }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be the matrix.os should come at the end of the name, but no strong preference.

path: ./bin/testreports
retention-days: 1
-
Expand Down