util/tracing: switch to semconv v1.37.0 #6385
Merged
+3
−10,338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/dependencies
align with otel/sdk and docker/cli on using the same version Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
bump_semconv
branch
from
c4c9cff to
2293eb3
Compare
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
commented
Dec 2, 2025
Comment on lines
43
to
46
| span.RecordError(err) | ||
| if hasStacktrace(err) { | ||
| span.SetAttributes(attribute.String(string(semconv.ExceptionStacktraceKey), fmt.Sprintf("%+v", stack.Formatter(err)))) | ||
| span.SetAttributes(semconv.ExceptionStacktrace(fmt.Sprintf("%+v", stack.Formatter(err)))) | ||
| } |
Member
Author
There was a problem hiding this comment.
Note that span.RecordError itself also can provide a stack-trace; wondering what that looks like or if that's not giving the same amount of detail as the ones we get from this custom code;
buildkit/vendor/go.opentelemetry.io/auto/sdk/span.go
Lines 327 to 338 in a13afb5
jsternberg
approved these changes
Dec 5, 2025
tonistiigi
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
util/tracing: switch to semconv v1.37.0
align with otel/sdk and docker/cli on using the same version