Skip to content

util/tracing: switch to semconv v1.37.0 #6385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tonistiigi merged 2 commits into from
Dec 5, 2025
+3 −10,338
Merged

util/tracing: switch to semconv v1.37.0 #6385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2293eb3
util/tracing: switch to semconv v1.37.0
thaJeztah Nov 27, 2025
7e9480c
util/tracing: use ExceptionStacktrace helper
thaJeztah Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion util/tracing/detect/resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import (
"go.opentelemetry.io/otel"
"go.opentelemetry.io/otel/sdk"
"go.opentelemetry.io/otel/sdk/resource"
semconv "go.opentelemetry.io/otel/semconv/v1.26.0"
semconv "go.opentelemetry.io/otel/semconv/v1.37.0"
)

var (
Expand Down
5 changes: 2 additions & 3 deletions util/tracing/tracing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,9 @@ import (
"github.com/pkg/errors"
"go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace"
"go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp"
"go.opentelemetry.io/otel/attribute"
"go.opentelemetry.io/otel/codes"
"go.opentelemetry.io/otel/propagation"
semconv "go.opentelemetry.io/otel/semconv/v1.26.0"
semconv "go.opentelemetry.io/otel/semconv/v1.37.0"
"go.opentelemetry.io/otel/trace"
"go.opentelemetry.io/otel/trace/noop"
)
Expand Down Expand Up @@ -43,7 +42,7 @@ func FinishWithError(span trace.Span, err error) {
if err != nil {
span.RecordError(err)
if hasStacktrace(err) {
span.SetAttributes(attribute.String(string(semconv.ExceptionStacktraceKey), fmt.Sprintf("%+v", stack.Formatter(err))))
span.SetAttributes(semconv.ExceptionStacktrace(fmt.Sprintf("%+v", stack.Formatter(err))))
}
Comment on lines 43 to 46
Copy link
Member Author

@thaJeztah thaJeztah Dec 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that span.RecordError itself also can provide a stack-trace; wondering what that looks like or if that's not giving the same amount of detail as the ones we get from this custom code;

buildkit/vendor/go.opentelemetry.io/auto/sdk/span.go

Lines 327 to 338 in a13afb5

cfg := trace.NewEventConfig(opts...)
attrs := cfg.Attributes()
attrs = append(attrs,
semconv.ExceptionType(typeStr(err)),
semconv.ExceptionMessage(err.Error()),
)
if cfg.StackTrace() {
buf := make([]byte, 2048)
n := runtime.Stack(buf, false)
attrs = append(attrs, semconv.ExceptionStacktrace(string(buf[0:n])))
}

span.SetStatus(codes.Error, err.Error())
}
Expand Down
3 changes: 0 additions & 3 deletions vendor/go.opentelemetry.io/otel/semconv/v1.26.0/README.md
View file
Open in desktop

This file was deleted.

8,996 changes: 0 additions & 8,996 deletions vendor/go.opentelemetry.io/otel/semconv/v1.26.0/attribute_group.go
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions vendor/go.opentelemetry.io/otel/semconv/v1.26.0/doc.go
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions vendor/go.opentelemetry.io/otel/semconv/v1.26.0/exception.go
View file
Open in desktop

This file was deleted.

1,307 changes: 0 additions & 1,307 deletions vendor/go.opentelemetry.io/otel/semconv/v1.26.0/metric.go
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions vendor/go.opentelemetry.io/otel/semconv/v1.26.0/schema.go
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion vendor/modules.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -908,7 +908,6 @@ go.opentelemetry.io/otel/internal/baggage
go.opentelemetry.io/otel/internal/global
go.opentelemetry.io/otel/propagation
go.opentelemetry.io/otel/semconv/v1.21.0
go.opentelemetry.io/otel/semconv/v1.26.0
go.opentelemetry.io/otel/semconv/v1.37.0
go.opentelemetry.io/otel/semconv/v1.37.0/httpconv
go.opentelemetry.io/otel/semconv/v1.37.0/otelconv
Expand Down
Loading