Bug fix: Synonym sync exclusions #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The exclusions were only excluding on matching scope. Now, they will exclude any instance of a synonym for a given mondo_id, regardless of scope, so long as they are in the exclusion config.
This was referenced Jan 12, 2025
|
See: results from applying on |
8 tasks
|
@twhetzel I know you are out, but if you run the builds this week, we need to merge this first right? I see you approved related PR: And we'd also want to merge this which fixes the other QC failures: |
twhetzel
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
The results of this code change look good in monarch-initiative/mondo#8562 and this is correct that any synonym in Mondo with the EXCLUDE annotation should be excluded in the Synonym Sync regardless of the synonym scope designation between what's in Mondo and the annotation in the external source ontology.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qc-related-exact-synonym.sparqlin NEVER MERGE: Test PR for adding synonyms mondo#8463Overview
The exclusions were only excluding on matching scope. Now, they will exclude any instance of a synonym for a given
mondo_id, regardless of scope, so long as they are in the exclusion config.Pre-merge checklist
Documentation
Was the documentation added/updated under
docs/?QC
Was the full pipeline run before submitting this PR using
sh run.sh make build-mondo-ingeston this branch (afterdocker pull obolibrary/odkfull:dev), and no errors occurred?Mini build:
New Packages
Were any new Python packages added?
Were any other non-Python packages added?
PR Review and Conversations Resolved
Has the PR been sufficiently reviewed by at least 1 team member of the Mondo Technical team and all threads resolved?