Draft
Conversation
matentzn
reviewed
Feb 19, 2024
Member
matentzn
left a comment
matentzn
left a comment
There was a problem hiding this comment.
I dont feel empowered to review this by FWIW LGTM.
| series (OMIMPS), which are represented as grouping classes in Mondo. Notes about | ||
| the OMIMPS (see also OMIM_phenotypic_series.yaml): - every instance of the OMIMPS | ||
| series (OMIMPS), which are represented as grouping classes in Mondo, and (2) OMIA Mendelian diseases (https://omia.org/) which are defined by a variation in a gene. | ||
| Notes about the OMIMPS (see also OMIM_phenotypic_series.yaml): - every instance of the OMIMPS |
Member
There was a problem hiding this comment.
Missing new line before the "every instance"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #7271
The pattern OMIM_disease_series_by_gene refers to the variable "disease" as "MONDO:0000001", which is the parent term of "human disease" and "non-human disease".
Therefore, this pattern could be used for both genetic diseases for human (from OMIM) and non-human animal (from OMIA).
I updated the existing description to reflect the above.
Note that I did not rename the pattern because it has been used "everywhere" in the ontology.
@matentzn @cmungall @katiermullen