Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add NCIT x-refs #8581

Merged
merged 3 commits into from
Jan 17, 2025
Merged

add NCIT x-refs #8581

merged 3 commits into from
Jan 17, 2025

Conversation

katiermullen
Copy link
Collaborator

addresses #8567

@katiermullen
Copy link
Collaborator Author

@sabrinatoro I am still having some proxy-merge issues. I have some questions about what I should do in these cases. Do I manually remove the NCIT x-ref from the one term where it does not belong (in cases where it is on the wrong term)? I just want to make sure that I am doing this right.

Oh, and then for submandibular gland cancer. Should I keep the NCIT x-ref to the more narrow term submandibular gland carcinoma? If so, what did I do wrong here?

Thank you for your help!

@katiermullen
Copy link
Collaborator Author

@sabrinatoro this finally passed. Please review at your convenience.

Copy link
Collaborator

@sabrinatoro sabrinatoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only one comment. I will let @nicolevasilevsky share her thoughts.
Except for this one comment, everything looks good.

Copy link
Collaborator

@sabrinatoro sabrinatoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katiermullen one change requested. Please see comment. Thank you.

@katiermullen
Copy link
Collaborator Author

@sabrinatoro requested change made. Please review

Copy link
Collaborator

@sabrinatoro sabrinatoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!
Approving and merging

@sabrinatoro sabrinatoro merged commit 343bdfe into master Jan 17, 2025
1 check passed
@sabrinatoro sabrinatoro deleted the issue-8657-1 branch January 17, 2025 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants