Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update exclusion-disease-gene.tsv #190

Closed
wants to merge 2 commits into from
Closed

update exclusion-disease-gene.tsv #190

wants to merge 2 commits into from

Conversation

joeflack4
Copy link
Contributor

@joeflack4 joeflack4 commented Jan 31, 2025

This update is based on this PR

NOTE: SOP is needed surrounding this exclusion document. (In addition, we need to create a standard for the exclusion reason).

Joe: This is a re-opening of #187, which was accidentally merged too soon.

This update is based on [this PR](monarch-initiative/mondo#8624)

NOTE: SOP is needed surrounding this exclusion document.
(In addition, we need to create a standard for the exclusion reason).
OMIM:619478 MONDO:0030355 facioscapulohumeral muscular dystrophy 4, digenic https://orcid.org/0000-0002-4142-7153 digenic
OMIM:300818 MONDO:0010438 paroxysmal nocturnal hemoglobinuria 1 https://orcid.org/0000-0002-4142-7153 "disease caused by a somatic mutation, therefore a gene association stating this is due to a germline mutation should not be added"
OMIM:278850 MONDO:0010218 46,XX sex reversal 2 https://orcid.org/0000-0002-4142-7153 "evidence that familial 46,XX sex reversal is caused by heterozygous duplication or triplication of a 68-kb regulatory region (XXSR) -584 to -516 kb upstream of the SOX9 gene (608160) on chromosome 17q24."
Copy link
Contributor

@twhetzel twhetzel Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the new definition that the exclusion file is for gene associations that are otherwise valid by the "rule", but after curator review it is decided that the gene association should not be added into Mondo as disease defining, only OMIM:278850 MONDO:0010218 46,XX sex reversal 2 should be maintained in the exclusion file. See comment here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. There was a lot of rows changed as well, but it looks like it may have just been TSV formatting. I thought Sabrina had manually removed/added other entries. I thought that the one case in that comment was just 1 example; not the only row that should be in here.

If that is indeed the only entry that should be in here, I'll change this file now. I'll do it in this PR, as well as #188 (and run the release again for it).

@joeflack4
Copy link
Contributor Author

Closing this in favor of:

@joeflack4 joeflack4 closed this Feb 6, 2025
@joeflack4 joeflack4 deleted the 250130ST branch February 6, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants