This repository has been archived by the owner on Feb 21, 2024. It is now read-only.
feat: allow usage with [email protected] #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
force-pushed
the
mongodb-6
branch
2 times, most recently
from
2e056a8 to
1af2c8a
Compare
addaleax
changed the title
lerouxb
reviewed
Aug 29, 2023
Comment on lines
+44
to
45
| "mongodb": "^5.4.0 || ^6.0.0", | ||
| "mongodb-log-writer": "^1.2.0" |
There was a problem hiding this comment.
I did not know that you could use || in there. TIL.
lerouxb
reviewed
Aug 29, 2023
| @@ -134,7 +134,7 @@ async function resolveMongodbSrv(uri: string, logger: ConnectLogEmitter): Promis | |||
| resolutionDetails.push({ | |||
| query: 'SRV', hostname, error: args[0]?.message, wasNativelyLookedUp: wasNativelyLookedUp(args[1]) | |||
| }); | |||
| // eslint-disable-next-line node/no-callback-literal | |||
| // eslint-disable-next-line n/no-callback-literal | |||
There was a problem hiding this comment.
Just out of curiosity: why was this renamed?
There was a problem hiding this comment.
https://github.com/eslint-community/eslint-plugin-n
forked from eslint-plugin-node v11.1.0. as the original repository seems no longer maintained.
lerouxb
approved these changes
Aug 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.