This repository has been archived by the owner on Feb 21, 2024. It is now read-only.
feat: allow usage with [email protected] #34
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -98,7 +98,7 @@ async function connectWithFailFast(uri: string, client: MongoClient, logger: Con | |
| client.removeListener('serverHeartbeatFailed', heartbeatFailureListener); | ||
| client.removeListener('serverHeartbeatSucceeded', heartbeatSucceededListener); | ||
| logger.emit('devtools-connect:connect-attempt-finished', { | ||
| cryptSharedLibVersionInfo: (client as any)?.autoEncrypter?.cryptSharedLibVersionInfo | ||
| }); | ||
| } | ||
| } | ||
|
|
@@ -134,7 +134,7 @@ async function resolveMongodbSrv(uri: string, logger: ConnectLogEmitter): Promis | |
| resolutionDetails.push({ | ||
| query: 'SRV', hostname, error: args[0]?.message, wasNativelyLookedUp: wasNativelyLookedUp(args[1]) | ||
| }); | ||
| // eslint-disable-next-line n/no-callback-literal | ||
|
There was a problem hiding this comment. Just out of curiosity: why was this renamed? There was a problem hiding this comment. https://github.com/eslint-community/eslint-plugin-n
|
||
| cb(...args); | ||
| }); | ||
| }, | ||
|
|
@@ -143,7 +143,7 @@ async function resolveMongodbSrv(uri: string, logger: ConnectLogEmitter): Promis | |
| resolutionDetails.push({ | ||
| query: 'TXT', hostname, error: args[0]?.message, wasNativelyLookedUp: wasNativelyLookedUp(args[1]) | ||
| }); | ||
| // eslint-disable-next-line n/no-callback-literal | ||
| cb(...args); | ||
| }); | ||
| } | ||
|
|
@@ -343,9 +343,9 @@ export async function connectMongoClient( | |
| const client = new MongoClientClass(uri, mongoClientOptions); | ||
| closeMongoClientWhenAuthFails(state, client); | ||
| await connectWithFailFast(uri, client, logger); | ||
| if ((client as any).autoEncrypter) { | ||
| // Enable Devtools-specific CSFLE result decoration. | ||
| ((client as any).autoEncrypter)[Symbol.for('@@mdb.decorateDecryptionResult')] = true; | ||
| } | ||
| return { client, state }; | ||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not know that you could use || in there. TIL.