LG-4749: Code loading skeleton
#2663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into LG-4760/code-copy-button
tsck
reviewed
Jan 29, 2025
.changeset/chatty-ears-exercise.md
Outdated
| @@ -45,6 +46,20 @@ e.g. | |||
| </Code> | |||
| ``` | |||
|
|
|||
| ### `isLoading` | |||
| Adds a new prop, `isLoading`. This prop determines whether or not the loading skeleton will be rendered in place of the code block. If 'true`, the language switcher and copy button will be disabled in the top panel. | |||
There was a problem hiding this comment.
Suggested change
| Adds a new prop, `isLoading`. This prop determines whether or not the loading skeleton will be rendered in place of the code block. If 'true`, the language switcher and copy button will be disabled in the top panel. | |
| Adds a new prop, `isLoading`. This prop determines whether or not the loading skeleton will be rendered in place of the code block. If `true`, the language switcher and copy button will be disabled in the top panel. |
.changeset/chatty-ears-exercise.md
Outdated
| title="Title" | ||
| /> | ||
| } | ||
| panel={ <Panel title="Title" />} |
There was a problem hiding this comment.
Very nit
Suggested change
| panel={ <Panel title="Title" />} | |
| panel={<Panel title="Title" />} |
packages/code/README.md
Outdated
| @@ -87,6 +87,7 @@ const SomeComponent = () => ( | |||
| | `highlightLines` | `Array<number` \| `[number, number]>` | An optional array of lines to highlight. The array can only contain numbers corresponding to the line numbers to highlight, and / or tuples representing a range (e.g. `[6, 10]`); | | | |||
| | `copyButtonAppearance` | `'none'`, `'hover'`, `'persist'` | Determines the appearance of the copy button if the panel prop is not defined. If `panel` is defined, this prop will be ignored. The copy button allows the code block to be copied to the user's clipboard by clicking the button. If `hover`, the copy button will only appear when the user hovers over the code block. On mobile devices, the copy button will always be visible. If `persist`, the copy button will always be visible. If `none`, the copy button will not be rendered. | `hover` | | |||
| | `panel` | `React.ReactNode` | Slot to pass the `<Panel/>` sub-component which will render the top panel with a language switcher, custom action buttons, and copy button. If no props are passed to the panel sub-component, the panel will render with only the copy button. | `` | | |||
| | `isLoading` | `boolean` | Determines whether or not the loading skeleton will be rendered in place of the code block. If 'true`, the language switcher and copy button will be disabled in the top panel. | `false` | | |||
There was a problem hiding this comment.
Suggested change
| | `isLoading` | `boolean` | Determines whether or not the loading skeleton will be rendered in place of the code block. If 'true`, the language switcher and copy button will be disabled in the top panel. | `false` | | |
| | `isLoading` | `boolean` | Determines whether or not the loading skeleton will be rendered in place of the code block. If `true`, the language switcher and copy button will be disabled in the top panel. | `false` | |
| @@ -60,6 +60,7 @@ export function LanguageSwitcherWithPanelExample({ | |||
|
|
|||
| return ( | |||
| <Code | |||
| {...rest} | |||
There was a problem hiding this comment.
We're still spreading rest on line 74 as well.
| width: 100%; | ||
| `, | ||
| className, | ||
| ); |
There was a problem hiding this comment.
I like just passing the className in here instead of also importing cx into the component to combine them!
sandynguyenn
approved these changes
Jan 29, 2025
Base automatically changed from
LG-4760/code-copy-button
to
LG-4657-code-improvements-integration
January 30, 2025 18:38
tsck
requested changes
Jan 31, 2025
There was a problem hiding this comment.
Still have some text left over from conflict in this file
There was a problem hiding this comment.
This was hard to fix, so I copied it from the integration branch and added back the isLoading prop
tsck
approved these changes
Jan 31, 2025
shaneeza
merged commit c8bc612
into
LG-4657-code-improvements-integration
10 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
🎟 Jira ticket: LG-4749
This PR adds the
isLoadingprop. When this prop istrue, the loading skeleton will render instead of the code block. If there is a panel, the language switcher and copy button will be disabled.✅ Checklist
For bug fixes, new features & breaking changes
pnpm changesetand documented my changesFor new components
🧪 How to test changes