-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LG-4749: Code
loading skeleton
#2663
Merged
shaneeza
merged 126 commits into
LG-4657-code-improvements-integration
from
LG-4749-code-isLoading
Jan 31, 2025
Merged
Changes from all commits
Commits
Show all changes
126 commits
Select commit
Hold shift + click to select a range
ef34493
wip
shaneeza b71de4e
wip - updating panel styles
shaneeza 029a90e
updated panel styles
shaneeza 6ef16ba
trying to combine styles
shaneeza 794fe08
move styles to styles file
shaneeza 2e19572
updating panel types
shaneeza e21b374
added context
shaneeza 07426d1
ts docs
shaneeza 9994560
update copy button styles in panel
shaneeza 3af02dc
organize code style file
shaneeza ffb7c2f
update types
shaneeza db94d82
remove unused type
shaneeza 68f6b57
wip code tests
shaneeza 02ede13
add language prop to context
shaneeza 56c69e5
more tests updates
shaneeza 79f9394
remove some tests
shaneeza ac0cadf
delete windowChrome and CustomSelectMenuButton
shaneeza 893f021
fix onChangeError
shaneeza 2fd12a6
remove comment
shaneeza a1d68a6
check if language is in option
shaneeza 2a35411
add copyButtonAppearance prop
shaneeza f7164ca
add clipboard check
shaneeza 05f3f67
Merge branch 'LG-4748-code-panel' of github.com:mongodb/leafygreen-ui…
shaneeza 9e108d7
remove copyable prop
shaneeza d1ecc7b
copy button styles
shaneeza b1f40b1
wip adding isLoadingProp
shaneeza bbf2a2d
add isLoading to context
shaneeza 5b4276f
disabled copy icon styles
shaneeza da970a8
isLoading tests
shaneeza 696bcd7
added back props i initially deleted
shaneeza 597eba3
remove props from context
shaneeza bf064a6
update tsdocs
shaneeza 2b77d46
rename func and update tsdocs
shaneeza 8a6c5e3
add todo tests
shaneeza e41fac7
adding more tests
shaneeza 1e4a020
remove unused tests
shaneeza 84c7542
merge conflict
shaneeza d561827
merge conflict
shaneeza b461adc
fix languageswitcher example
shaneeza 85037f5
fix errors
shaneeza 90ab34c
fix errors
shaneeza f35d883
remove copyable false
shaneeza 7b04bc6
add error test
shaneeza c2fc2b0
update tests and tsdocs
shaneeza fd23e6a
clean up
shaneeza f45e3a7
testids
shaneeza eadcc1b
merge conflicts
shaneeza 485b0fc
merge conflict
shaneeza a5d6008
dont skip test
shaneeza 36972e5
Merge branch 'LG-4748-code-panel' of github.com:mongodb/leafygreen-ui…
shaneeza f7611b1
Merge branch 'LG-4760/code-copy-button' of github.com:mongodb/leafygr…
shaneeza a2a44f5
update padding
shaneeza 571a0c7
updating generate stories
shaneeza 339e8be
fix story error
shaneeza 3d284ed
Merge branch 'LG-4748-code-panel' of github.com:mongodb/leafygreen-ui…
shaneeza 3de4d8e
merge conflict
shaneeza a02a756
fix build error
shaneeza e88a6f9
Merge branch 'main' of github.com:mongodb/leafygreen-ui into LG-4748-…
shaneeza 64aefdc
clean up
shaneeza c45e257
Merge branch 'main' of github.com:mongodb/leafygreen-ui into LG-4748-…
shaneeza 6c42aa6
readme updates
shaneeza 7e9898e
forgot to save
shaneeza 500ab13
fix language type
shaneeza 5f5ecfb
lint
shaneeza 8a8d39c
more tests
shaneeza 394ae5e
remove fireevent
shaneeza cd99321
fix dep errors
shaneeza db02b0e
update lock file
shaneeza 4255681
merge conflict
shaneeza 6ca77cb
add generated stories
shaneeza e1030de
lint
shaneeza 149ff69
title fix
shaneeza 9a45d18
Merge branch 'LG-4748-code-panel' of github.com:mongodb/leafygreen-ui…
shaneeza 62f8b52
remove unused code and add new styles for button
shaneeza f43f0fb
updates
shaneeza a5123a1
lint
shaneeza 10b22b5
forgot to save
shaneeza 9f0da7e
merge conflict
shaneeza b4cd95f
loading story
shaneeza b10b6f6
lint
shaneeza 4975572
some cleanup
shaneeza 9a8bada
update test to use context
shaneeza 8184e9a
fix spelling
shaneeza a3dd9c4
Merge branch 'LG-4760/code-copy-button' of github.com:mongodb/leafygr…
shaneeza 3ac48a6
remove comments
shaneeza bd339cf
lint
shaneeza a292195
remove comment
shaneeza ec6b9d4
Merge branch 'LG-4748-code-panel' of github.com:mongodb/leafygreen-ui…
shaneeza b4dca10
update test
shaneeza d1f5264
merge conflict
shaneeza 2ac9395
feedback
shaneeza 56afc5a
changeset
shaneeza facac67
typos
shaneeza a39be45
rephrase
shaneeza 705a6c2
update test
shaneeza b9da5f9
Merge branch 'LG-4748-code-panel' of github.com:mongodb/leafygreen-ui…
shaneeza 7fcbe7f
readme
shaneeza e051c3c
update docs
shaneeza 55f6527
clean up
shaneeza 4e322db
lib changeset
shaneeza e05cfda
test order
shaneeza cf28e29
add ticket
shaneeza dd51f84
update docs
shaneeza 1168eb3
fix story props
shaneeza 33538df
sandy feedback
shaneeza 1d1deb3
fix build error
shaneeza 5f1c58c
merge conflict
shaneeza 49625f4
merge conflict
shaneeza 813d6f4
build and story updates
shaneeza 48a968a
lock
shaneeza daff28f
update genereated stories
shaneeza b8de180
showPanel and story updates
shaneeza b8ec8e5
add showCopyButtonWithoutPanel const
shaneeza 0e23069
remove extra div
shaneeza 0cce4b0
discriminated union for copyButtonAppearnce and panel
shaneeza e0d7288
use getMobileMediaQuery in select
shaneeza 40839f8
changeset
shaneeza 7dd19e7
doc feedback
shaneeza 3beac53
fix tooltip issue and be more specific with svg styles
shaneeza 47b0a0d
merge conflict
shaneeza a7ec53e
add isLoading check
shaneeza b5af1af
merge conflict
shaneeza 164f544
fix disabled copy button styles
shaneeza 6923499
docs
shaneeza acb8e86
remove dup copy button
shaneeza 05b9e4d
fix readme
shaneeza File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still have some text left over from conflict in this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oof
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was hard to fix, so I copied it from the integration branch and added back the
isLoading
propThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense!