[LG-5686] fix(avatar): use unique gradient IDs in AssistantAvatar #3373
+14
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephl3
requested review from
TheSonOfThomp,
Copilot and
shaneeza
and removed request for
a team
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where multiple AssistantAvatar components on the same page would have conflicting SVG gradient IDs, causing incorrect rendering. The fix replaces a hardcoded gradient ID constant with dynamic IDs generated using the useIdAllocator hook.
Key Changes:
- Replaced hardcoded
GRADIENT_IDconstant with dynamic gradient IDs usinguseIdAllocator - Added
@leafygreen-ui/hooksas a dependency to the avatar package
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/avatar/src/AssistantAvatar/AssistantAvatar.tsx | Removed hardcoded gradient ID constant and implemented useIdAllocator hook to generate unique IDs per component instance |
| packages/avatar/package.json | Added @leafygreen-ui/hooks workspace dependency |
| packages/avatar/tsconfig.json | Added TypeScript project reference to the hooks package |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Contributor
|
Size Change: +82 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
Contributor
shaneeza
reviewed
Dec 10, 2025
| }: AssistantAvatarProps) => { | ||
| const { darkMode, theme } = useDarkMode(darkModeProp); | ||
| const fill = disabled ? getDisabledFill(theme) : `url(#${GRADIENT_ID})`; | ||
| const gradientId = useIdAllocator({ |
Collaborator
There was a problem hiding this comment.
Do we need a changeset for this?
Collaborator
There was a problem hiding this comment.
Just realized that there is already a changeset. Approving!
shaneeza
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
This PR updates
AssistantAvatarto useuseIdAllocatorfrom@leafygreen-ui/hooksto generate unique gradient IDs instead of a hardcoded constant. This prevents ID collisions when multipleAssistantAvatarcomponents are rendered on the same page, which could cause incorrect gradient rendering.🎟️ Jira ticket: LG-5686
✅ Checklist
pnpm changesetand documented my changes🧪 How to test changes
AssistantAvatarcomponents on the same page (e.g., in a Storybook story)