Skip to content

[LG-5686] fix(avatar): use unique gradient IDs in AssistantAvatar #3373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephl3 merged 2 commits into from
Dec 11, 2025
+14 −4
Merged

[LG-5686] fix(avatar): use unique gradient IDs in AssistantAvatar #3373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23a5890
chore(avatar): add @leafygreen-ui/hooks dep
stephl3 Dec 9, 2025
41f9c3c
fix(avatar): use unique id for AssistantAvatar gradient
stephl3 Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/avatar/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
},
"dependencies": {
"@leafygreen-ui/emotion": "workspace:^",
"@leafygreen-ui/hooks": "workspace:^",
"@leafygreen-ui/icon": "workspace:^",
"@leafygreen-ui/lib": "workspace:^",
"@leafygreen-ui/logo": "workspace:^",
Expand Down
11 changes: 7 additions & 4 deletions packages/avatar/src/AssistantAvatar/AssistantAvatar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import React from 'react';

import { useIdAllocator } from '@leafygreen-ui/hooks';
import { createGlyphComponent } from '@leafygreen-ui/icon';
import { useDarkMode } from '@leafygreen-ui/leafygreen-provider';

Expand All @@ -10,8 +11,6 @@ import {
} from './AssistantAvatar.styles';
import { AssistantAvatarProps } from './AssistantAvatar.types';

const GRADIENT_ID = 'sparkle-gradient';

export const AssistantAvatar: React.ComponentType<AssistantAvatarProps> =
createGlyphComponent(
'Sparkle',
Expand All @@ -21,7 +20,11 @@ export const AssistantAvatar: React.ComponentType<AssistantAvatarProps> =
...rest
}: AssistantAvatarProps) => {
const { darkMode, theme } = useDarkMode(darkModeProp);
const fill = disabled ? getDisabledFill(theme) : `url(#${GRADIENT_ID})`;
const gradientId = useIdAllocator({
Copy link
Collaborator

@shaneeza shaneeza Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a changeset for this?

Copy link
Collaborator

@shaneeza shaneeza Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized that there is already a changeset. Approving!

prefix: 'lg-assistant_avatar-gradient',
id: rest.id,
});
const fill = disabled ? getDisabledFill(theme) : `url(#${gradientId})`;
const gradientStartColor = getGradientStartColor(darkMode);
const gradientEndColor = getGradientEndColor(darkMode);

Expand All @@ -38,7 +41,7 @@ export const AssistantAvatar: React.ComponentType<AssistantAvatarProps> =
{!disabled && (
<defs>
<linearGradient
id={GRADIENT_ID}
id={gradientId}
x1="3.00005"
y1="3"
x2="12.5001"
Expand Down
3 changes: 3 additions & 0 deletions packages/avatar/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@
{
"path": "../emotion"
},
{
"path": "../hooks"
},
{
"path": "../icon"
},
Expand Down
3 changes: 3 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading