PYTHON-5103 Convert test.test_server_selection_rtt to async #2122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoahStapp
requested changes
Feb 3, 2025
Co-authored-by: Noah Stapp <[email protected]>
NoahStapp
requested changes
Feb 3, 2025
sleepyStick
commented
Feb 3, 2025
| @@ -226,6 +226,7 @@ def async_only_test(f: str) -> bool: | |||
| "test_retryable_writes.py", | |||
| "test_retryable_writes_unified.py", | |||
| "test_session.py", | |||
| "test_server_selection_rtt.py", | |||
There was a problem hiding this comment.
is this not the synchro change for this file?
There was a problem hiding this comment.
Whoops wrong PR sorry, looks good!
There was a problem hiding this comment.
all good, there are too many PRs in flight rn, i'm struggling to keep track of them all in reviews HAHA
NoahStapp
previously approved these changes
Feb 4, 2025
NoahStapp
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.