-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PYTHON-5103 Convert test.test_server_selection_rtt to async #2122
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
22e7f55
Convert test.test_server_selection_rtt to async
sleepyStick 7f579d4
Update test/asynchronous/test_server_selection_rtt.py
sleepyStick f09b24f
Merge branch 'master' into PYTHON-5103
sleepyStick 8e1605b
run pre-commit
sleepyStick e8c9c54
Merge branch 'master' into PYTHON-5103
sleepyStick File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,77 @@ | ||
# Copyright 2015 MongoDB, Inc. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
"""Test the topology module.""" | ||
from __future__ import annotations | ||
|
||
import json | ||
import os | ||
import sys | ||
from pathlib import Path | ||
|
||
sys.path[0:0] = [""] | ||
|
||
from test import unittest | ||
from test.asynchronous import AsyncPyMongoTestCase | ||
|
||
from pymongo.read_preferences import MovingAverage | ||
|
||
_IS_SYNC = False | ||
|
||
# Location of JSON test specifications. | ||
if _IS_SYNC: | ||
TEST_PATH = os.path.join(Path(__file__).resolve().parent, "server_selection/rtt") | ||
else: | ||
TEST_PATH = os.path.join(Path(__file__).resolve().parent.parent, "server_selection/rtt") | ||
|
||
|
||
class TestAllScenarios(AsyncPyMongoTestCase): | ||
pass | ||
|
||
|
||
def create_test(scenario_def): | ||
def run_scenario(self): | ||
moving_average = MovingAverage() | ||
|
||
if scenario_def["avg_rtt_ms"] != "NULL": | ||
moving_average.add_sample(scenario_def["avg_rtt_ms"]) | ||
|
||
if scenario_def["new_rtt_ms"] != "NULL": | ||
moving_average.add_sample(scenario_def["new_rtt_ms"]) | ||
|
||
self.assertAlmostEqual(moving_average.get(), scenario_def["new_avg_rtt"]) | ||
|
||
return run_scenario | ||
|
||
|
||
def create_tests(): | ||
for dirpath, _, filenames in os.walk(TEST_PATH): | ||
dirname = os.path.split(dirpath)[-1] | ||
|
||
for filename in filenames: | ||
with open(os.path.join(dirpath, filename)) as scenario_stream: | ||
scenario_def = json.load(scenario_stream) | ||
|
||
# Construct test from scenario. | ||
new_test = create_test(scenario_def) | ||
test_name = f"test_{dirname}_{os.path.splitext(filename)[0]}" | ||
|
||
new_test.__name__ = test_name | ||
setattr(TestAllScenarios, new_test.__name__, new_test) | ||
|
||
|
||
create_tests() | ||
|
||
if __name__ == "__main__": | ||
unittest.main() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this not the synchro change for this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops wrong PR sorry, looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good, there are too many PRs in flight rn, i'm struggling to keep track of them all in reviews HAHA