Android: Remove unused parentContext parameter from MicTranscriber constructor#119
Open
shubham0204 wants to merge 1 commit intomoonshine-ai:mainfrom
Open
Android: Remove unused parentContext parameter from MicTranscriber constructor#119shubham0204 wants to merge 1 commit intomoonshine-ai:mainfrom
parentContext parameter from MicTranscriber constructor#119shubham0204 wants to merge 1 commit intomoonshine-ai:mainfrom
Conversation
The member 'parentContext' of type 'AppCompatActivity' is not used in the implementation of MicTranscriber class.
shubham0204
changed the title
parentContext parameter from MicTranscriber constructorparentContext parameter from MicTranscriber constructor
shubham0204
changed the title
parentContext parameter from MicTranscriber constructorparentContext parameter from MicTranscriber constructor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The member
parentContextof typeAppCompatActivityis not used in the implementation ofMicTranscriberclass.I am integrating Moonshine ASR in SmolChat, an app built on top of llama.cpp that enables users to chat with local SLMs (GGUFs). The app uses Koin as its dependency injection framework. Currently,
MicTranscriberrequires an instance ofAppCompatActivityin its constructor which is difficult for Koin to inject. Koin operates across the lifecycle of the application and getting the instance of the current activity is not straight-forward. Solving this problem motivated me to check the usages ofparentContextinMicTranscriber.Also, the codebase is neatly organized for different platforms/languages. Kudos to the developers!
@petewarden @keveman