Skip to content

Android: Remove unused parentContext parameter from MicTranscriber constructor #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shubham0204 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Android: Remove unused parentContext parameter from MicTranscriber constructor #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions android/java/main/java/ai/moonshine/voice/MicTranscriber.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,14 @@

public class MicTranscriber extends Transcriber {
private boolean isRunning = false;
private AppCompatActivity parentContext;
private boolean isMicCaptureLoopStarted = false;
private MicCaptureProcessor micCaptureProcessor;
private CompletableFuture<Void> isLoadedSignal = new CompletableFuture<>();
private CompletableFuture<Void> hasMicPermissionSignal =
new CompletableFuture<>();

public MicTranscriber(AppCompatActivity parentContext) {
public MicTranscriber() {
super();
this.parentContext = parentContext;
// When both isLoadedSignal and hasMicPermissionSignal are complete, run
// startProcessing()
CompletableFuture.allOf(isLoadedSignal, hasMicPermissionSignal)
Expand Down