Skip to content

Conversation

@lilla28
Copy link
Contributor

@lilla28 lilla28 commented Nov 3, 2025

Implemented

  • GetUserChannels
  • FindIntent
  • GetOrCreateChannel
  • FindInstances
  • FindIntentsByContext
  • RaiseIntentForContext
  • RaiseIntent
  • AddIntentListener
  • Open
  • CreatePrivateChannel

@lilla28 lilla28 requested a review from a team as a code owner November 3, 2025 14:44
@lilla28 lilla28 force-pushed the feat/fdc3--net-client-missing branch 2 times, most recently from 4373050 to 0582a09 Compare November 3, 2025 17:13
@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

❌ Patch coverage is 66.92776% with 380 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.8%. Comparing base (64b13ac) to head (971b370).
⚠️ Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
...Infrastructure/Internal/Protocol/PrivateChannel.cs 51.0% 89 Missing and 23 partials ⚠️
...estHelpers/DesktopAgentClientConsoleApp/Program.cs 0.0% 77 Missing ⚠️
...t.Client/Infrastructure/Internal/IntentListener.cs 65.3% 31 Missing and 12 partials ⚠️
...pAgent.Client/Infrastructure/DesktopAgentClient.cs 63.3% 21 Missing and 12 partials ⚠️
...rnal/PrivateChannelContextListenerEventListener.cs 29.0% 21 Missing and 1 partial ⚠️
.../Internal/PrivateChannelDisconnectEventListener.cs 30.0% 20 Missing and 1 partial ⚠️
...oseUI.Fdc3.DesktopAgent/Fdc3DesktopAgentService.cs 36.6% 16 Missing and 3 partials ⚠️
....Client/Infrastructure/Internal/ContextListener.cs 37.9% 13 Missing and 5 partials ⚠️
...nt.Client/Infrastructure/Internal/IntentsClient.cs 92.8% 5 Missing and 6 partials ⚠️
...t.Client/Infrastructure/Internal/ChannelFactory.cs 93.3% 6 Missing and 3 partials ⚠️
... and 6 more

❌ Your patch status has failed because the patch coverage (66.9%) is below the target coverage (100.0%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #1114     +/-   ##
=======================================
+ Coverage   64.3%   65.8%   +1.4%     
=======================================
  Files        325     334      +9     
  Lines       8681    9761   +1080     
  Branches    1102    1229    +127     
=======================================
+ Hits        5587    6427    +840     
- Misses      2781    2957    +176     
- Partials     313     377     +64     
Files with missing lines Coverage Δ
...DependencyInjection/ServiceCollectionExtensions.cs 100.0% <100.0%> (ø)
...t.Client/Infrastructure/Internal/MetadataClient.cs 94.8% <100.0%> (+1.9%) ⬆️
...Client/Infrastructure/Internal/Protocol/Channel.cs 96.0% <100.0%> (ø)
...ternal/Protocol/PrivateChannelInternalEventType.cs 100.0% <100.0%> (ø)
...topAgent.Shared/Converters/ContextJsonConverter.cs 100.0% <ø> (ø)
...pAgent.Shared/Converters/ValuationJsonConverter.cs 100.0% <100.0%> (ø)
....Fdc3.DesktopAgent.Shared/Fdc3StartupParameters.cs 100.0% <ø> (ø)
...dc3.DesktopAgent.Shared/SerializerOptionsHelper.cs 100.0% <100.0%> (ø)
...DependencyInjection/ServiceCollectionExtensions.cs 100.0% <100.0%> (ø)
....ComposeUI.Fdc3.DesktopAgent/Fdc3ShutdownAction.cs 68.0% <100.0%> (ø)
... and 20 more

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lilla28 lilla28 force-pushed the feat/fdc3--net-client-missing branch 3 times, most recently from 3c21957 to 4869eeb Compare November 6, 2025 17:20
@lilla28 lilla28 force-pushed the feat/fdc3--net-client-missing branch from c992f66 to 953d65e Compare November 25, 2025 15:56
…pAgent

- Add semaphore lock to DesktopAgentClient for safe channel access
- Ensure initialization before channel operations
- Clarify error messages; introduce new error codes (NoInstanceFound, NoAppIntent)
- Add ThrowHelper method for backend error reporting
- Use Interlocked.Increment for intent message IDs in IntentsClient
- Fix spelling/grammar in comments and errors
- Remove unnecessary semaphore in ContextListener
- Standardize instance ID usage in PrivateChannel
@lilla28 lilla28 force-pushed the feat/fdc3--net-client-missing branch from 953d65e to 9e8e561 Compare November 26, 2025 10:23
@lilla28 lilla28 merged commit a35a466 into morganstanley:main Dec 3, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants