-
Notifications
You must be signed in to change notification settings - Fork 29
feat(fdc3) - Add leftover FDC3 native client implementation #1114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lilla28
merged 18 commits into
morganstanley:main
from
lilla28:feat/fdc3--net-client-missing
Dec 3, 2025
Merged
feat(fdc3) - Add leftover FDC3 native client implementation #1114
lilla28
merged 18 commits into
morganstanley:main
from
lilla28:feat/fdc3--net-client-missing
Dec 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4373050 to
0582a09
Compare
psmulovics
reviewed
Nov 3, 2025
...ed/src/MorganStanley.ComposeUI.Fdc3.DesktopAgent.Shared/Converters/ValuationJsonConverter.cs
Show resolved
Hide resolved
ZKRobi
requested changes
Nov 5, 2025
examples/dotnet-diagnostics/DiagnosticsExample/MainWindow.xaml.cs
Outdated
Show resolved
Hide resolved
...c/MorganStanley.ComposeUI.Fdc3.DesktopAgent.Client/Infrastructure/Internal/ChannelFactory.cs
Outdated
Show resolved
Hide resolved
...c/MorganStanley.ComposeUI.Fdc3.DesktopAgent.Client/Infrastructure/Internal/ChannelFactory.cs
Outdated
Show resolved
Hide resolved
...nStanley.ComposeUI.Fdc3.DesktopAgent.Client.Tests/Infrastructure/DesktopAgentClient.Tests.cs
Show resolved
Hide resolved
...pAgent.Shared/src/MorganStanley.ComposeUI.Fdc3.DesktopAgent.Shared/Exceptions/ThrowHelper.cs
Outdated
Show resolved
Hide resolved
...UI.Fdc3.DesktopAgent.Client/Infrastructure/Internal/PrivateChannelDisconnectEventListener.cs
Outdated
Show resolved
Hide resolved
...tanley.ComposeUI.Fdc3.DesktopAgent.Client/Infrastructure/Internal/Protocol/PrivateChannel.cs
Show resolved
Hide resolved
...tanley.ComposeUI.Fdc3.DesktopAgent.Client/Infrastructure/Internal/Protocol/PrivateChannel.cs
Outdated
Show resolved
Hide resolved
...dotnet/DesktopAgent/src/MorganStanley.ComposeUI.Fdc3.DesktopAgent/Fdc3DesktopAgentService.cs
Show resolved
Hide resolved
...ed/src/MorganStanley.ComposeUI.Fdc3.DesktopAgent.Shared/Converters/ValuationJsonConverter.cs
Show resolved
Hide resolved
ZKRobi
reviewed
Nov 5, 2025
...lient/src/MorganStanley.ComposeUI.Fdc3.DesktopAgent.Client/Infrastructure/IChannelFactory.cs
Outdated
Show resolved
Hide resolved
3c21957 to
4869eeb
Compare
…nceId is defined, refactored RaiseIntentForContext method; Implemented AddIntentListener<T> for FDC3 Native client
…e native FDC3 client
…tored passing,handling opened app context, fixed typos, changed exceptions, user channel now is included without DisplayMetadata, fixed example app to use StringBuilder fix(native-example-app) - using stringbuilder
… indentation for NuGet package description
c992f66 to
953d65e
Compare
…pAgent - Add semaphore lock to DesktopAgentClient for safe channel access - Ensure initialization before channel operations - Clarify error messages; introduce new error codes (NoInstanceFound, NoAppIntent) - Add ThrowHelper method for backend error reporting - Use Interlocked.Increment for intent message IDs in IntentsClient - Fix spelling/grammar in comments and errors - Remove unnecessary semaphore in ContextListener - Standardize instance ID usage in PrivateChannel
953d65e to
9e8e561
Compare
ZKRobi
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented
GetUserChannelsFindIntentGetOrCreateChannelFindInstancesFindIntentsByContextRaiseIntentForContextRaiseIntentAddIntentListenerOpenCreatePrivateChannel