Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wstETH/ETH oracle using exchange rate only #65

Merged
merged 50 commits into from
Mar 5, 2024
Merged

wstETH/ETH oracle using exchange rate only #65

merged 50 commits into from
Mar 5, 2024

Conversation

MerlinEgalite
Copy link
Contributor

Fixes #64

@MerlinEgalite MerlinEgalite requested review from QGarchery, MathisGD, a team, Rubilmax and Jean-Grimal and removed request for a team January 23, 2024 18:19
@MerlinEgalite MerlinEgalite marked this pull request as draft January 23, 2024 18:28
@MerlinEgalite MerlinEgalite marked this pull request as ready for review January 23, 2024 20:11
Jean-Grimal
Jean-Grimal previously approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@Jean-Grimal Jean-Grimal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Rubilmax
Rubilmax reviewed Jan 29, 2024
View reviewed changes
src/adapters/WstEthOracle.sol Outdated Show resolved Hide resolved
src/adapters/WstEthOracle.sol Outdated Show resolved Hide resolved
src/adapters/WstEthOracle.sol Outdated Show resolved Hide resolved
src/adapters/WstEthOracle.sol Outdated Show resolved Hide resolved
test/WstEthOracle.sol Outdated Show resolved Hide resolved
test/WstEthOracle.sol Outdated Show resolved Hide resolved
Jean-Grimal
Jean-Grimal previously approved these changes Jan 29, 2024
View reviewed changes
Rubilmax
Rubilmax previously approved these changes Jan 29, 2024
View reviewed changes
QGarchery
QGarchery reviewed Jan 29, 2024
View reviewed changes
Copy link
Contributor

@QGarchery QGarchery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It's possible to simplify a little bit

src/adapters/WstEthChainlinkAdapter.sol Outdated Show resolved Hide resolved
src/adapters/WstEthChainlinkAdapter.sol Outdated Show resolved Hide resolved
test/WstEthChainlinkAdapterTest.sol Outdated Show resolved Hide resolved
Rubilmax
Rubilmax previously approved these changes Feb 20, 2024
View reviewed changes
Jean-Grimal
Jean-Grimal previously approved these changes Feb 20, 2024
View reviewed changes
@MathisGD MathisGD dismissed stale reviews from Jean-Grimal and Rubilmax via ad5e168 March 5, 2024 11:12
Rubilmax
Rubilmax previously approved these changes Mar 5, 2024
View reviewed changes
Jean-Grimal
Jean-Grimal previously approved these changes Mar 5, 2024
View reviewed changes
@MerlinEgalite MerlinEgalite dismissed stale reviews from Jean-Grimal and Rubilmax via ac54cd1 March 5, 2024 13:39
@MathisGD MathisGD merged commit 756347b into main Mar 5, 2024
2 checks passed
@MathisGD MathisGD deleted the feat/wsteth-oracle branch March 5, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathisGD MathisGD MathisGD approved these changes

@Rubilmax Rubilmax Rubilmax approved these changes

@Jean-Grimal Jean-Grimal Jean-Grimal approved these changes

@QGarchery QGarchery QGarchery approved these changes

@adhusson adhusson Awaiting requested review from adhusson

Assignees

@MerlinEgalite MerlinEgalite

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write wstETH oracle using exchange rate
6 participants
@MerlinEgalite @adhusson @Rubilmax @QGarchery @MathisGD @Jean-Grimal