fix(#309): Provider-specific JSON Schema for OpenAI/Gemini structured output - #310
Merged
Merged
Conversation
- Add llm_json_schema_adaptation: oneOf→anyOf, strip discriminator for OpenAI strict mode - Apply same union normalization for Vertex Gemini response_schema - Bedrock unchanged (passes through; ignores schema) - Unit tests for EmailInsightResponse / provider routing Made-with: Cursor
4 tasks
mottych
added a commit
that referenced
this pull request
Apr 10, 2026
coaching/pyproject.toml lacked [tool.ruff.lint.isort] known-first-party, so Ruff treated coaching.* as third-party and failed I001 (e.g. unified_ai_engine.py), breaking CI/CD and Deploy Dev after #310. Add known-first-party matching repo root; apply ruff check --fix across coaching/ for consistent import blocks. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes OpenAI 400 \invalid_json_schema\ for discriminated unions (e.g. \EmailInsightResponse.blocks): Pydantic emits \oneOf, which OpenAI strict structured outputs reject under \items.
Changes
Testing
Closes #309.
Made with Cursor