revision: remove unused Revision.commit_id field (Bug 1995895)#632
Closed
cgsheeh wants to merge 1 commit intomozilla-conduit:mainfrom
Closed
revision: remove unused Revision.commit_id field (Bug 1995895)#632cgsheeh wants to merge 1 commit intomozilla-conduit:mainfrom
Revision.commit_id field (Bug 1995895)#632cgsheeh wants to merge 1 commit intomozilla-conduit:mainfrom
Conversation
cgsheeh
commented
Oct 22, 2025
| # A general purpose data field to store arbitrary information about this revision. | ||
| data = models.JSONField(blank=True, default=dict) | ||
|
|
||
| # The commit ID generated by the landing worker, before pushing to remote repo. |
Member
Author
There was a problem hiding this comment.
After taking a quick look at adding commit_id to the intermediate table, I noticed that we set the diff_id on the intermediate table by using the currently set Revision.diff_id. I think if we wanted to use the same pattern for setting the commit_id, we would need to keep this field around and update it. Happy to set the revision IDs using an argument to the method instead, just wanted to point that out. 👍
Contributor
There was a problem hiding this comment.
Hm yeah I think it makes sense to do it the same way (maybe even in the same method, after renaming the method.)
EDIT: that, or re-implement both in a different way, just think it would make sense to be consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.