Skip to content

revision: remove unused Revision.commit_id field (Bug 1995895) #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cgsheeh wants to merge 1 commit into from
Closed

revision: remove unused Revision.commit_id field (Bug 1995895) #632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/lando/main/migrations/0032_remove_revision_commit_id.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Generated by Django 5.2.7 on 2025-10-22 19:54

from django.db import migrations


class Migration(migrations.Migration):

dependencies = [
("main", "0031_alter_landingjob_requester_email"),
]

operations = [
migrations.RemoveField(
model_name="revision",
name="commit_id",
),
]
3 changes: 0 additions & 3 deletions src/lando/main/models/revision.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,6 @@ class Revision(BaseModel):
# A general purpose data field to store arbitrary information about this revision.
data = models.JSONField(blank=True, default=dict)

# The commit ID generated by the landing worker, before pushing to remote repo.
Copy link
Copy Markdown
Member Author

@cgsheeh cgsheeh Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After taking a quick look at adding commit_id to the intermediate table, I noticed that we set the diff_id on the intermediate table by using the currently set Revision.diff_id. I think if we wanted to use the same pattern for setting the commit_id, we would need to keep this field around and update it. Happy to set the revision IDs using an argument to the method instead, just wanted to point that out. 👍

Copy link
Copy Markdown
Contributor

@zzzeid zzzeid Oct 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm yeah I think it makes sense to do it the same way (maybe even in the same method, after renaming the method.)

EDIT: that, or re-implement both in a different way, just think it would make sense to be consistent.

commit_id = models.CharField(max_length=40, null=True, blank=True)

_patch_helper: Optional[HgPatchHelper] = None

def __str__(self) -> str:
Expand Down