Refactor FXIOS-13481 [Swift 6 Migration] Turn on Concurrency for TabDataStoreTests in BrowserKit #29763 #29765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dataports
commented
Oct 3, 2025
|
|
||
| extension XCTestCase { | ||
| // TODO: Needs group discussion on solution for warnings | ||
| func trackForMemoryLeaks(_ instance: AnyObject, file: StaticString = #filePath, line: UInt = #line) { |
There was a problem hiding this comment.
This will need updating pending a discussion, see: #29741 (comment)
If someone wants to pick up that work after a solution is found they can, but I can also do it when I return from PTO. This PR is opened for convenience.
|
This PR has been automatically marked as stale. Please leave any comment to keep this PR opened. It will be closed automatically if no further update occurs in the next 7 days. Thank you for your contributions! |
github-actions
bot
added
the
stale
github-actions
bot
removed
the
stale
|
Closing for now until we can find a solution for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
Turn on TabDataStoreTests in BrowserKit.
Warnings
TODO comment:
Pending discussion with the team this will need to be updated before merging.
See discussion on previous PR
cc: @ih-codes @Cramsden
📝 Checklist