Skip to content

Refactor FXIOS-13481 [Swift 6 Migration] Turn on Concurrency for TabDataStoreTests in BrowserKit #29763 #29765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Refactor FXIOS-13481 [Swift 6 Migration] Turn on Concurrency for TabDataStoreTests in BrowserKit #29763 #29765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f717b38
Enable strict concurrency for TabDataStoreTests
dataports Oct 3, 2025
030e3d6
Add Todo
dataports Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion BrowserKit/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,11 @@ let package = Package(
.enableExperimentalFeature("StrictConcurrency")]),
.testTarget(
name: "TabDataStoreTests",
dependencies: ["TabDataStore"]),
dependencies: ["TabDataStore"],
swiftSettings: [
.enableExperimentalFeature("StrictConcurrency"),
]
),
.target(
name: "Redux",
dependencies: ["Common"],
Expand Down
1 change: 1 addition & 0 deletions BrowserKit/Tests/TabDataStoreTests/XCTestCaseExtension.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import Foundation
import XCTest

extension XCTestCase {
// TODO: Needs group discussion on solution for warnings
func trackForMemoryLeaks(_ instance: AnyObject, file: StaticString = #filePath, line: UInt = #line) {
Copy link
Contributor Author

@dataports dataports Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need updating pending a discussion, see: #29741 (comment)

If someone wants to pick up that work after a solution is found they can, but I can also do it when I return from PTO. This PR is opened for convenience.

addTeardownBlock { [weak instance] in
XCTAssertNil(
Expand Down
Loading