Refactor FXIOS-13755 [Stories Feed] Update strings to title case

[Foxbolts]

📜 Tickets

Jira ticket
Github issue

💡 Description

• Use title case for stories feed strings
• Since all of these features are behind a flag that has not been enabled in production yet, we are able to replace the strings with updated keys, and remove the old ones

📝 Checklist

• I filled in the ticket numbers and a description of my work
• I updated the PR name to follow our PR naming guidelines
• I ensured unit tests pass and wrote tests for new code
• If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
• If adding telemetry, I read the data stewardship requirements and will request a data review
• If adding or modifying strings, I read the guidelines and will request a string review from l10n
• If needed, I updated documentation and added comments to complex code

[mobiletest-ci-bot]

	Messages
📖	Project coverage: 38.16%

✍️ Strings Updated

Detected changes in Shared/Strings.swift.
To keep strings up to standards, please tag a member of the firefox-ios-l10n team for review. 🌍

🧹 Tidy commit

Just 2 file(s) touched. Thanks for keeping it clean and review-friendly!

✅ Per-file coverage

All changed files meet the threshold of 35.0%.

Client.app: Coverage: 37.34

File	Coverage
StoriesFeedViewController.swift	71.27%	✅

Generated by 🚫 Danger Swift against 2e155a3

[lmarceau]

Since I tagged Delphine, I'll comment here too (and not just in DM).

Is the StoriesFeedViewController code released already? Those strings were already exported to l10n, hence the question. We can't modify strings in-place if they are used, we need to move them to the oldStrings struct, and create new strings

[lmarceau]

Ah! It was said in the description 🤦‍♀️

Since all of these features are behind a flag that has not been enabled in production yet, we are able to replace the strings with updated keys, and remove the old ones

So I think this is fine.

[Foxbolts]

Since I tagged Delphine, I'll comment here too (and not just in DM).

Is the StoriesFeedViewController code released already? Those strings were already exported to l10n, hence the question. We can't modify strings in-place if they are used, we need to move them to the oldStrings struct, and create new strings

The StoriesFeedViewController (which contains the AllStoriesViewTitle string) is not user-facing yet, and the other two strings (PopularTodaySectionTitle and AllStoriesButtonTitle) are also behind feature flags and not user-facing yet

[mergify]

This pull request has conflicts when rebasing. Could you fix it @Foxbolts? 🙏

[github-actions]

🚀 PR merged to main, targeting version: 144.1