Skip to content

Refactor FXIOS-13755 [Stories Feed] Update strings to title case #29816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2025
Merged

Refactor FXIOS-13755 [Stories Feed] Update strings to title case #29816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ac884a
update strings to title case
Foxbolts Oct 3, 2025
2e155a3
update usage
Foxbolts Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion firefox-ios/Client/Frontend/StoriesFeed/StoriesFeedViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ class StoriesFeedViewController: UIViewController,

// MARK: Helper functions
private func setupNavigationBar(animated: Bool) {
title = .FirefoxHomepage.Pocket.TopStories.TopStoriesViewTitle
title = .FirefoxHomepage.Pocket.AllStories.AllStoriesViewTitle
navigationController?.setNavigationBarHidden(false, animated: animated)
}

Expand Down
18 changes: 9 additions & 9 deletions firefox-ios/Shared/Strings.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1036,14 +1036,14 @@ extension String {
value: "Stories",
comment: "This is the title of the Stories section on Firefox Homepage.")
public static let PopularTodaySectionTitle = MZLocalizedString(
key: "FirefoxHome.Stories.PopularTodaySectionTitle.v144",
key: "FirefoxHome.Stories.PopularTodaySectionTitle.v145",
tableName: "FirefoxHomepage",
value: "Popular today",
value: "Popular Today",
comment: "This is the title of the stories section on Firefox Homepage, which displays a collection of trending news articles")
public static let AllStoriesButtonTitle = MZLocalizedString(
key: "FirefoxHome.Stories.AllStoriesButtonTitle.v144",
key: "FirefoxHome.Stories.AllStoriesButtonTitle.v145",
tableName: "FirefoxHomepage",
value: "All stories",
value: "All Stories",
comment: "This is the title for the button next to the stories section title on Firefox Homepage that, when tapped, transitions you to the Top Stories view which displays a collection of trending news articles.")
public static let NumberOfMinutes = MZLocalizedString(
key: "FirefoxHome.Stories.Minutes.v140",
Expand Down Expand Up @@ -1073,12 +1073,12 @@ extension String {
value: "%@ of %@",
comment: "On the homepage, in the Stories section, this is the accessibility hint for the position of the current story in the stories stack. The first placeholder, %1$@, is the current position; the second placeholder, %2$@, is the total story count. Example: '1 of 5'")

public struct TopStories {
public static let TopStoriesViewTitle = MZLocalizedString(
key: "FirefoxHome.Stories.TopStoriesViewTitle.v144",
public struct AllStories {
public static let AllStoriesViewTitle = MZLocalizedString(
key: "FirefoxHome.Stories.AllStoriesViewTitle.v145",
tableName: "FirefoxHomepage",
value: "Top stories",
comment: "This is the title that appears in the navigation bar for the Top Stories view, a screen that displays a collection of trending news articles")
value: "All Stories",
comment: "This is the title that appears in the navigation bar for the All Stories view, a screen that displays a collection of trending news articles")
}
}

Expand Down
Loading