Try eliminating some flakiness in Playwright welcome/* specs #16777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephaniehobson
pushed a commit
that referenced
this pull request
Oct 21, 2025
* Add more steps to firefox-welcome-6 test spec * Update firefox-welcome-4 test spec for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
Some integration tests are annotated as flaky. This adds an extra check to slow down the interaction.
Significant changes and points to review
The fade-in/fade-out of the overlay seems slower than what Playwright hits, according to the trace steps it seems for some reason it's already in the "success" state when it times out waiting for the button 🤷 Let's see if this helps.
(Also moves the syntax closer between the two specs.)
Issue / Bugzilla link
https://github.com/mozilla/bedrock/actions/runs/18190607844/job/51784617662#step:5:52
https://github.com/mozilla/bedrock/actions/runs/18131722256/job/51600555642#step:5:75
Testing
https://github.com/janbrasna/bedrock/actions/runs/18208012190
👇
https://github.com/mozilla/bedrock/actions/runs/18688291744
✅
┆Issue is synchronized with this Jira Task
┆Priority: P2
┆Sprint: Backlog