Skip to content

Try eliminating some flakiness in Playwright welcome/* specs #16777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2025
Merged

Try eliminating some flakiness in Playwright welcome/* specs #16777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
994a06c
Add more steps to firefox-welcome-6 test spec
janbrasna Oct 2, 2025
2477a8e
Update firefox-welcome-4 test spec for consistency
janbrasna Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions tests/playwright/specs/products/firefox/welcome/firefox-welcome-4.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@

const { test, expect } = require('@playwright/test');
const openPage = require('../../../../scripts/open-page');
const url = '/firefox/welcome/4/';
const url = 'firefox/welcome/4';

test.describe(
`${url} page`,
{
tag: ['@firefox', '@wfc-redirect']
tag: '@firefox'
},
() => {
test('Send to device form success', async ({ page, browserName }) => {
Expand All @@ -22,7 +22,7 @@ test.describe(
'Page shown to Firefox browsers only'
);

await openPage('/en-US/' + url, page, browserName);
await openPage(`/en-US/${url}/`, page, browserName);

const qrCode = page.getByTestId('firefox-qr-code');
const emailField = page.getByTestId(
Expand All @@ -37,6 +37,7 @@ test.describe(

await expect(qrCode).not.toBeVisible();
await expect(thanksMessage).not.toBeVisible();
await expect(submitButton).toBeVisible();
await emailField.fill('[email protected]');
await submitButton.click();
await expect(submitButton).not.toBeVisible();
Expand All @@ -49,7 +50,7 @@ test.describe(
'Page shown to Firefox browsers only'
);

await openPage('/en-US/' + url, page, browserName);
await openPage(`/en-US/${url}/`, page, browserName);

const qrCode = page.getByTestId('firefox-qr-code');
const emailField = page.getByTestId(
Expand All @@ -62,6 +63,7 @@ test.describe(

await expect(qrCode).not.toBeVisible();
await expect(errorMessage).not.toBeVisible();
await expect(submitButton).toBeVisible();
await emailField.fill('[email protected]');
await submitButton.click();
await expect(errorMessage).toBeVisible();
Expand All @@ -73,7 +75,7 @@ test.describe(
'Page shown to Firefox browsers only'
);

await openPage('/sv-SE/' + url, page, browserName);
await openPage(`/fy-NL/${url}/`, page, browserName);

const qrCode = page.getByTestId('firefox-qr-code');
const emailField = page.getByTestId(
Expand Down
10 changes: 6 additions & 4 deletions tests/playwright/specs/products/firefox/welcome/firefox-welcome-6.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@

const { test, expect } = require('@playwright/test');
const openPage = require('../../../../scripts/open-page');
const url = '/firefox/welcome/6/';
const url = 'firefox/welcome/6';

test.describe(
`${url} page`,
{
tag: ['@firefox', '@wfc-redirect']
tag: '@firefox'
},
() => {
test('Send set as default button displayed', async ({
test('Set as default button displayed', async ({
page,
browserName
}) => {
Expand Down Expand Up @@ -55,6 +55,7 @@ test.describe(
await getAppButton.click();
await expect(qrCode).not.toBeVisible();
await expect(thanksMessage).not.toBeVisible();
await expect(submitButton).toBeVisible();
await emailField.fill('[email protected]');
await submitButton.click();
await expect(submitButton).not.toBeVisible();
Expand Down Expand Up @@ -82,6 +83,7 @@ test.describe(
await getAppButton.click();
await expect(qrCode).not.toBeVisible();
await expect(errorMessage).not.toBeVisible();
await expect(submitButton).toBeVisible();
await emailField.fill('[email protected]');
await submitButton.click();
await expect(errorMessage).toBeVisible();
Expand All @@ -93,7 +95,7 @@ test.describe(
'Page shown to Firefox browsers only'
);

await openPage(`/it/${url}/?default=true`, page, browserName);
await openPage(`/fy-NL/${url}/?default=true`, page, browserName);

const getAppButton = page.getByTestId('button-firefox-get-app');
const qrCode = page.getByTestId('firefox-qr-code');
Expand Down