Fix download tests by changing channels for now #16781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbrasna
changed the title
janbrasna
commented
Oct 9, 2025
| # FIXME: sanity checks after first scene is redirected to FXC: | ||
| if product_urls and product_urls[0].startswith("/en-US/download/all/"): | ||
| product_urls = ["/en-US/firefox/all/desktop-release/", "/en-US/firefox/all/desktop-nightly/"] | ||
| product_urls = ["/en-US/firefox/all/desktop-release/", "/en-US/firefox/all/desktop-esr/"] |
There was a problem hiding this comment.
This basically silences the 404s (that are genuinely present on these not-yet-redirected-but-quite-buried-and-hard-to-get-to pages and won't get updated, only the pages removed…) for another month so that more things could get pointed at fxc in the meantime. It's still left in to get triggered with the next train again in four weeks to remind this needs a real solution anyway.
stevejalim
approved these changes
Oct 13, 2025
stephaniehobson
pushed a commit
that referenced
this pull request
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
Removes Nightly from l10n download tests as i686 builds listed are no longer available.
Significant changes and points to review
Following up from #16425 — the tests did their job and surfaced
firefox-145.0a1.*.linux-i686are not available going forward. This will need resolving via #16367 but this gives us some sanity check utility of the tests otherwise running for a while now.Issue / Bugzilla link
https://bugzil.la/1987132
See also #16765, #16367
Testing
docker compose run test pytest --base-url https://www.mozilla.org -m download┆Issue is synchronized with this Jira Task
┆Priority: P2
┆Sprint: Backlog