Skip to content

Fix download tests by changing channels for now #16781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2025
Merged

Fix download tests by changing channels for now #16781

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/functional/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def pytest_generate_tests(metafunc):
product_urls = [a.attrib["href"] for a in doc("ul.c-product-list a")]
# FIXME: sanity checks after first scene is redirected to FXC:
if product_urls and product_urls[0].startswith("/en-US/download/all/"):
product_urls = ["/en-US/firefox/all/desktop-release/", "/en-US/firefox/all/desktop-nightly/"]
product_urls = ["/en-US/firefox/all/desktop-release/", "/en-US/firefox/all/desktop-esr/"]
Copy link
Collaborator Author

@janbrasna janbrasna Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This basically silences the 404s (that are genuinely present on these not-yet-redirected-but-quite-buried-and-hard-to-get-to pages and won't get updated, only the pages removed…) for another month so that more things could get pointed at fxc in the meantime. It's still left in to get triggered with the next train again in four weeks to remind this needs a real solution anyway.

# If product url links outside of /firefox/all/ ignore it. (e.g. testflight)
product_urls = [url for url in product_urls if url.startswith("/en-US/firefox/all/")]
for url in product_urls:
Expand Down