implemented buildMap todo for kotlin#1717
Merged
bendk merged 3 commits intomozilla:mainfrom Sep 27, 2023
Merged
Conversation
jmartinesp
reviewed
Aug 25, 2023
Comment on lines
+5
to
+6
| return buildMap<{{ key_type_name }}, {{ value_type_name }}> { | ||
| val len = buf.getInt() |
Contributor
There was a problem hiding this comment.
There is a buildMap variant that takes a capacity parameter and should be more performant, maybe the len value could be used for that?
val len = buf.getInt()
return buildMap<{{ key_type_name }}, {{ value_type_name }}>(len) {
Contributor
Author
There was a problem hiding this comment.
Thank you, didn't notice that. Fixed.
Contributor
Author
|
build failing because of rust dependencies |
Member
|
If you rebase on |
514a3f8 to
331098f
Compare
bendk
approved these changes
Sep 27, 2023
Contributor
bendk
left a comment
There was a problem hiding this comment.
CI is passing, let's take this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there was todo to use buildMap, it is stable since Kotlin 1.6
implemented todo
note - I was not able to run tests from doker image with
But I hope they will run in PR flow now.