Skip to content

implemented buildMap todo for kotlin #1717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bendk merged 3 commits into from
Sep 27, 2023
Merged

implemented buildMap todo for kotlin #1717

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
887d014
implemented buildMap todo for kotlin
Dmitry-Borodin Aug 22, 2023
c7c3c57
removed added space between }
Dmitry-Borodin Aug 22, 2023
331098f
optimised buildMap - create map of required capaticy to avoid expansion
Dmitry-Borodin Aug 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions uniffi_bindgen/src/bindings/kotlin/templates/MapTemplate.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,14 @@
{%- let value_type_name = value_type|type_name %}
public object {{ ffi_converter_name }}: FfiConverterRustBuffer<Map<{{ key_type_name }}, {{ value_type_name }}>> {
override fun read(buf: ByteBuffer): Map<{{ key_type_name }}, {{ value_type_name }}> {
// TODO: Once Kotlin's `buildMap` API is stabilized we should use it here.
val items : MutableMap<{{ key_type_name }}, {{ value_type_name }}> = mutableMapOf()
val len = buf.getInt()
repeat(len) {
val k = {{ key_type|read_fn }}(buf)
val v = {{ value_type|read_fn }}(buf)
items[k] = v
return buildMap<{{ key_type_name }}, {{ value_type_name }}>(len) {
repeat(len) {
val k = {{ key_type|read_fn }}(buf)
val v = {{ value_type|read_fn }}(buf)
this[k] = v
}
}
return items
}

override fun allocationSize(value: Map<{{ key_type_name }}, {{ value_type_name }}>): Int {
Expand Down