[DRAFT] rust: update to pre-release 1.69.0#16847
Closed
filnet wants to merge 1 commit intomsys2:masterfrom
Closed
Conversation
Contributor
Author
|
MINGW and UCRT fail with: this errorCLANG needs a patch adjustement. A fix is on its way. Note that the CLANG build with |
Contributor
Author
|
@mati865 any ideas why the MINGW build fails ? Could be related to : |
Contributor
Author
|
The issue is reminiscent of #10555 (comment) in the sense that PassBuilder.cpp.obj is involved again. Probably just a coincidence. |
Contributor
Author
|
Just noticed that it is EDIT: Nope, it is the CLANG build that uses |
Contributor
Author
|
I am pretty sure the issue is caused by the LLVM 16.0.0 upgrade that happened 3 weeks ago. The LLVM upgrade contains this change: llvm/llvm-project@95b27b2
Could making the template non const cause static linking to fail (i.e. the duplicate definitions cannot be merged because they are not const anymore)? |
Contributor
Author
|
Reverting the LLVM change fixes the build :) |
filnet
added a commit
to filnet/MINGW-packages
that referenced
this pull request
Apr 21, 2023
reverts this change: llvm/llvm-project@95b27b2 fixes the Rust build, see msys2#16847
Collaborator
|
Unfortunately i don't remember GCC template shenanigans but I guess it could be worth to give it a try. |
Contributor
Author
|
I opened an issue upstream : llvm/llvm-project#62270 |
filnet
added a commit
to filnet/MINGW-packages
that referenced
this pull request
Apr 22, 2023
reverts this change: llvm/llvm-project@95b27b2 fixes the Rust build, see msys2#16847
Contributor
Author
|
Switching to #16856 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://blog.rust-lang.org/inside-rust/2023/04/17/1.69.0-prerelease.html