fix: default to MSE except safari #1254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mium based browsers
|
@ronalduQualabs is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR updates the video player logic to default to MSE (Media Source Extensions) for all browsers except Safari, replacing the previous Chrome-specific detection. This change ensures caption availability works consistently across Chromium-based browsers while maintaining native HLS playback for Safari.
Key changes:
- Replaced Chrome version detection with Safari user agent detection
- Inverted the logic to use MSE by default for non-Safari browsers
- Removed unused
browserBrandsvariable
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
luwes
changed the title
luwes
approved these changes
Dec 9, 2025
Contributor
luwes
left a comment
luwes
left a comment
There was a problem hiding this comment.
LGTM 👍
Tested in MacOS Edge, Google Chrome, iOS Safari, iOS Safari with prefer playback mse
Merged
luwes
pushed a commit
that referenced
this pull request
Dec 10, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>@mux/mux-audio: 0.15.18</summary> ## [0.15.18](https://github.com/muxinc/elements/compare/@mux/[email protected]...@mux/[email protected]) (2025-12-10) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/playback-core bumped from 0.32.0 to 0.32.1 </details> <details><summary>@mux/mux-audio-react: 0.15.18</summary> ## [0.15.18](https://github.com/muxinc/elements/compare/@mux/[email protected]...@mux/[email protected]) (2025-12-10) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/playback-core bumped from 0.32.0 to 0.32.1 </details> <details><summary>@mux/mux-player: 3.10.1</summary> ## [3.10.1](https://github.com/muxinc/elements/compare/@mux/[email protected]...@mux/[email protected]) (2025-12-10) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/mux-video bumped from 0.29.0 to 0.29.1 * @mux/playback-core bumped from 0.32.0 to 0.32.1 </details> <details><summary>@mux/mux-player-astro: 3.10.1</summary> ## [3.10.1](https://github.com/muxinc/elements/compare/@mux/[email protected]...@mux/[email protected]) (2025-12-10) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/mux-player bumped from 3.10.0 to 3.10.1 * @mux/playback-core bumped from 0.32.0 to 0.32.1 </details> <details><summary>@mux/mux-player-react: 3.10.1</summary> ## [3.10.1](https://github.com/muxinc/elements/compare/@mux/[email protected]...@mux/[email protected]) (2025-12-10) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/mux-player bumped from 3.10.0 to 3.10.1 * @mux/playback-core bumped from 0.32.0 to 0.32.1 </details> <details><summary>@mux/mux-video: 0.29.1</summary> ## [0.29.1](https://github.com/muxinc/elements/compare/@mux/[email protected]...@mux/[email protected]) (2025-12-10) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/playback-core bumped from 0.32.0 to 0.32.1 </details> <details><summary>@mux/mux-video-react: 0.29.1</summary> ## [0.29.1](https://github.com/muxinc/elements/compare/@mux/[email protected]...@mux/[email protected]) (2025-12-10) ### Dependencies * The following workspace dependencies were updated * dependencies * @mux/playback-core bumped from 0.32.0 to 0.32.1 </details> <details><summary>@mux/playback-core: 0.32.1</summary> ## [0.32.1](https://github.com/muxinc/elements/compare/@mux/[email protected]...@mux/[email protected]) (2025-12-10) ### Bug Fixes * default to MSE except safari ([#1254](#1254)) ([f2411ad](f2411ad)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the video player logic to use MSE by default if its not Safari since. Chromium-based browsers with native HLS support were experiencing issues with captions not available. By defaulting to MSE except on Safari, we ensure captions work consistently across browsers.
Changes: