Skip to content

fix: default to MSE except safari #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luwes merged 10 commits into from
Dec 10, 2025
Merged

fix: default to MSE except safari #1254

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ebb6890
update
ronalduQualabs Mar 24, 2025
e8e3e5b
pr fix: remove private variable and observedAttributes
ronalduQualabs May 26, 2025
1e6093f
Merge remote-tracking branch 'upstream/main'
ronalduQualabs Aug 11, 2025
91cce76
Merge remote-tracking branch 'upstream/main'
ronalduQualabs Oct 29, 2025
b5def0a
Merge remote-tracking branch 'upstream/main'
ronalduQualabs Dec 9, 2025
540da92
Default to MSE for all browsers except Safari to fix captions in chro…
ronalduQualabs Dec 9, 2025
5707417
remove unnecesary project
ronalduQualabs Dec 9, 2025
b522a13
Merge branch 'main' into fix/default-to-mse-except-safari
ronalduQualabs Dec 9, 2025
a388246
restore turbo file
ronalduQualabs Dec 9, 2025
3341542
remove browserBrands
ronalduQualabs Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions packages/playback-core/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,6 @@ declare global {

const userAgentStr = globalThis?.navigator?.userAgent ?? '';
const userAgentPlatform = globalThis?.navigator?.userAgentData?.platform ?? '';
const browserBrands = globalThis?.navigator?.userAgentData?.brands ?? [];

// NOTE: Our primary *goal* with this is to detect "non-Apple-OS" platforms which may also support
// native HLS playback. Our primary concern with any check for this is "false negatives" where we
Expand All @@ -354,12 +353,8 @@ const isAndroidLike =
userAgentStr.toLowerCase().includes('android') ||
['x11', 'android'].some((platformStr) => userAgentPlatform.toLowerCase().includes(platformStr));

const googleChromeBrand = browserBrands.find((brand) => brand.brand === 'Google Chrome');

const isChromeWithNativeHLS = (mediaEl: Pick<HTMLMediaElement, 'canPlayType'>) =>
googleChromeBrand &&
parseInt(googleChromeBrand.version ?? '0') >= 141 &&
!!mediaEl.canPlayType('application/vnd.apple.mpegurl');
const isSafari = (mediaEl: Pick<HTMLMediaElement, 'canPlayType'>) =>
/^((?!chrome|android).)*safari/i.test(userAgentStr) && !!mediaEl.canPlayType('application/vnd.apple.mpegurl');

// NOTE: Exporting for testing
export const muxMediaState: WeakMap<
Expand All @@ -370,8 +365,7 @@ export const muxMediaState: WeakMap<
const MUX_VIDEO_DOMAIN = 'mux.com';
const MSE_SUPPORTED = Hls.isSupported?.();

const shouldDefaultToMSE = (mediaEl: Pick<HTMLMediaElement, 'canPlayType'>) =>
isAndroidLike || isChromeWithNativeHLS(mediaEl);
const shouldDefaultToMSE = (mediaEl: Pick<HTMLMediaElement, 'canPlayType'>) => isAndroidLike || !isSafari(mediaEl);

export const generatePlayerInitTime = () => {
return mux.utils.now();
Expand Down
Loading