fix route return #1076
Merged
fix route return #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabcor-maxiv
reviewed
Oct 3, 2023
| @@ -83,7 +83,7 @@ def set_func(): | |||
| args = request.get_json() | |||
| adapter = app.mxcubecore.get_adapter(obj.lower()) | |||
| adapter.execute_command(cmd_name, args) | |||
| return make_response("{}", 200) | |||
| return "Command executed successfull" | |||
There was a problem hiding this comment.
Are there cases where make_response returns None? When? Why?
There was a problem hiding this comment.
seems so, all the calls in this method, no clue why
|
Very nice, ill try to get the build working again after this dependency mess and then Ill try to rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same as before :)