Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix route return #1076

Merged
merged 2 commits into from
Oct 3, 2023
Merged

fix route return #1076

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d5281a
fix route return
meguiraun Oct 3, 2023
7c2e34d
smallest commit ever
meguiraun Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mxcube3/routes/beamline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def set_func():
args = request.get_json()
adapter = app.mxcubecore.get_adapter(obj.lower())
adapter.execute_command(cmd_name, args)
return make_response("{}", 200)
return "Command executed successfull"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

successfully

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there cases where make_response returns None? When? Why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems so, all the calls in this method, no clue why

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, odd


set_func.__name__ = f"{obj}_{cmd_name}"

Expand Down
Loading