Fix dual-monitor support on Linux

[larsiusprime]

Fixes this issue in OpenFL: openfl/lime#667

[ruby0x1]

@jgranick @larsiusprime did nobody read this discussion here?

randomnine#1

[ruby0x1]

anyone?

[larsiusprime]

No, I didn't see that.

So you want to hide these all behind a define that's turned on in the framework itself?

[ruby0x1]

I've elaborated in that thread but yea! Having tertiary build dependencies tacked on just to use the lib is not something that fits the model we're going for here.

[larsiusprime]

How many defines, 1 or multiple? Just give me some marching orders here and I'll clean it up.

[larsiusprime]

Also, added myself to the watch list here, I think that's why I didn't see your note before.

[ruby0x1]

Sure!
Note the existing native toolkit defines right on the lines below:

SDL_VIDEO_DRIVER_X11_XINPUT2 NATIVE_TOOLKIT_SDL_X11_XINPUT2

In this case, the build xml / framework specifies "I want to build with xinput2", and the dependency is added. This way, all existing users of the library aren't thrown to the wolves every week someone wants a new dependency, and they're opt in, not opt out - that's all it is :)

The same would be applied to the two new dependency changes, in the same way.
That should be a a quick search and copy paste edit to add them - one for each - from what I understand the actual lib names aren't a problem being defined, just the one with the 1 or 0.

The framework can then further collate flags as needed, and define it by default, which would subsequently define the two native toolkit defines as needed.

Let me know if that helps

[larsiusprime]

Like this?

#6

My understanding is any define is FALSE by default, but to be sure, do I have to explicitly define these somewhere in SDL as false, and then in the external framework make sure to flip them to true?

EDIT: okay, found the files.xml I need to update. Also:

What syntax to you prefer?

#ifdef THING
   #define OTHER_THING 1
#endif

#ifdef THING OTHER_THING