Feature/add crd nats 0.19.0 #1032
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenfoo
approved these changes
Aug 26, 2025
| version: 0.29.0 | ||
| appVersion: "0.18.2" | ||
| version: 0.29.1 | ||
| appVersion: "0.19.0" |
Contributor
There was a problem hiding this comment.
You may want to bump to "0.19.1" now.
Comment on lines
+235
to
+242
| allowMsgTtl: | ||
| description: When true, allows header initiated per-message TTLs. If disabled, then the `NATS-TTL` header will be ignored. | ||
| type: boolean | ||
| default: false | ||
| subjectDeleteMarkerTtl: | ||
| description: Enables and sets a duration for adding server markers for delete, purge and max age limits. | ||
| type: string | ||
| default: '' |
Contributor
There was a problem hiding this comment.
Nice! This should fix the warnings that we are seeing lately.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a strange situation here.
An updated CRD for new NACK release need to copy to k8s repo...
I think we can do this better in the future, but for now I just copied new CRD from here: https://github.com/nats-io/nack/blob/main/deploy/crds.yml