-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improved RPC's response error handling with HTTP status codes #11806
Conversation
cfbb08a
to
c7e7e6d
Compare
@shreyan-gupta Sorry, it took a bit longer than expected, but I removed Result from process function |
Co-authored-by: Shreyan Gupta <[email protected]>
644dbe6
to
c956802
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11806 +/- ##
==========================================
+ Coverage 71.74% 71.75% +0.01%
==========================================
Files 796 796
Lines 163004 163183 +179
Branches 163004 163183 +179
==========================================
+ Hits 116940 117095 +155
- Misses 41003 41038 +35
+ Partials 5061 5050 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@race-of-sloths please, include my PR in the Race |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! That has to be done long time ago, thank you!
This PR updates the RPC handler to return appropriate HTTP errors for specific RPC issues, improving error visibility for operators
closes #11792