Error messages refactoring #1854

lexfrl · 2019-12-12T10:44:27Z

All runtime errors implements serde::Serialize
Struct errors shouldn't use tuple structs
add an index of the failed Action for ActionError
FunctionCall error must be structured
FunctionCall in view?

MaksymZavershynskyi

Maybe we should also rename near-vm-errors to near-runtime-errors.

MaksymZavershynskyi · 2019-12-20T00:35:14Z

chain/jsonrpc/src/lib.rs

@@ -211,21 +233,18 @@ impl JsonRpcHandler {
        let result = self
            .client_addr
            .send(NetworkClientMessages::Transaction(tx))
-            .map_err(|err| RpcError::server_error(Some(convert_mailbox_error(err))))


@bowenwang1996 @frol In what cases RPC will return a MailboxError? AFAIU it only happens if the communication between the actors has timed out or the channel has been closed. The latter one can happen when the node is shutting down (btw, we need to implement a way to gracefully shutdown the node). The former one is not supposed to happen in our infra, since the communication between the actors does not have a timeout , correct?

Yes I think this error can only happen under extreme circumstances, but @evgenykuzyakov insisted that I handle it. I think it can also happen if the node receives too much traffic.

I see. @bowenwang1996 is it correct that communication between our Actix actors uses bounded channels that can overflow and drop the messages? Is it possible to arrive to an unforeseen state due to some messages being lost between the Actix actors? CC @SkidanovAlex

I am not sure. I think @frol knows actix better, but we in general should be resistant to lost messages.

It looks like Actix uses unbounded channels by the default, so it should be good unless we explicitly changed it. actix/actix#14

unbounded channels are the major source of unbounded memory consumption, and they tend to hide problems until it is too late.

core/primitives/src/errors.rs

lexfrl · 2019-12-20T15:50:27Z

Maybe we should also rename near-vm-errors to near-runtime-errors.

I agree.

lexfrl · 2019-12-23T11:54:43Z

Maybe we should also rename near-vm-errors to near-runtime-errors.

On a second though, near-vm-errors are essentially FunctionCall errors.. I'm not sure we should to rename it now. All "runtime errors" are in near-primitives ATM. And all the VM errors are in near-runtime.

core/primitives/src/errors.rs

MaksymZavershynskyi

Tracking issue #1972

tools/rpctypegen/Cargo.toml

scripts/build_errors_schema.sh

MaksymZavershynskyi · 2020-01-17T02:20:34Z

tools/rpctypegen/src/lib.rs

+    pub props: BTreeMap<String, String>,
+}
+
+thread_local!(static SCHEMA: RefCell<Schema> = RefCell::new(Schema::default()));


We should make sure procedural macroses are never executed by different threads.

rustc is a single-threaded AFAIK. I guess we are about to came up with the more robust solution in #1972 anyway.

It definitely runs parallelizes compilation of the crates across the processes or threads (I don't remember exactly, but you can see it for yourself in htop when you compile nearcore) so this schema is not going to be reused across the crates.

I meant rustc for a single crate is single-threded, but not an entire build process, sure. That's why it merges into the json file if the file exists. Of course it's far from ideal: there is a small chance that it will rewrite the file. Since it's already a hack (and will be rewritten at some point) and since it's not a runtime code I don't think it worth to make it perfect. If you have a better idea at hand - I'd be glad to apply it!

runtime/near-vm-errors/src/lib.rs

tools/rpctypegen/src/lib.rs

Co-Authored-By: Maksym Zavershynskyi <[email protected]>

…-rpc crate

core/primitives/src/errors.rs

evgenykuzyakov

Approving. Time to ship :)

evgenykuzyakov · 2020-01-21T22:37:56Z

chain/jsonrpc/Cargo.toml

+near-rpc-error-macro = { path = "../../tools/rpctypegen/macro" }
+
+[build-dependencies]
+_rand = { package = "rand", version = "0.6.5" }


Why do you need this specific version of rand?

It's a trick to make it compile. Take a look:

dalek-cryptography/ed25519-dalek#89

MaksymZavershynskyi · 2020-01-22T03:31:32Z

Events are now merged. This PR is unblocked.

Co-Authored-By: Evgeny Kuzyakov <[email protected]>

lexfrl · 2020-01-22T14:26:54Z

@nearmax your approval is needed

use VMError instead of String in FunctionCall error

775c141

lexfrl force-pushed the fckt/rpc-errors branch from d9e6953 to 775c141 Compare December 12, 2019 11:15

some progress on errors

5f2226f

lexfrl force-pushed the fckt/rpc-errors branch from 5f2226f to 775c141 Compare December 18, 2019 11:21

lexfrl added 7 commits December 18, 2019 16:05

errors refactor

a986bc7

revert changes (rename fields)

bc9910c

test pass

ad1e830

error view update

4cd0ff5

WIP

5fc2e61

make it compile

5696c99

tests pass

6515670

MaksymZavershynskyi reviewed Dec 20, 2019

View reviewed changes

lexfrl added 2 commits December 20, 2019 17:56

action index added to ActionError

27ab39b

action index added: test pass

3062291

lexfrl added 4 commits December 23, 2019 14:55

merge statging

8657d92

FunctionCall(String) -> FunctionCall(VMError)

6d7c555

rpctypegen start

52ebc4d

continue with RpcError derive_macro

a339c34

frol reviewed Dec 26, 2019

View reviewed changes

core/primitives/src/errors.rs Outdated Show resolved Hide resolved

core/primitives/src/errors.rs Outdated Show resolved Hide resolved

continue working

c32ddb9

frol reviewed Dec 27, 2019

View reviewed changes

core/primitives/src/errors.rs Outdated Show resolved Hide resolved

core/primitives/src/errors.rs Outdated Show resolved Hide resolved

errors JSON schema generation done

63e7cc4

MaksymZavershynskyi requested a review from evgenykuzyakov December 27, 2019 22:01

lexfrl added 4 commits December 30, 2019 19:07

Do not rewrite the schema file. Merge error schemas instead.

3aebd75

small fix

695c11b

VMErrors refactoring

212a430

expose errors schema

08f601f

lexfrl force-pushed the fckt/rpc-errors branch from 8027ee5 to 08f601f Compare January 3, 2020 19:23

lexfrl added 2 commits January 14, 2020 01:14

fix check_actor_permissions for DeleteAccount

a2ae077

no cargo clean in build_errors_schema.sh and move to scripts

879dffe

lexfrl requested a review from evgenykuzyakov January 14, 2020 12:31

feature-gated schema dump generation

c641f4a

lexfrl force-pushed the fckt/rpc-errors branch from 66331ed to c641f4a Compare January 14, 2020 16:53

Merge branch 'staging' into fckt/rpc-errors

b9ae3fd

MaksymZavershynskyi mentioned this pull request Jan 17, 2020

[Epic] Tofu -- Rust to other languages mapping tool #1972

Open

MaksymZavershynskyi suggested changes Jan 17, 2020

View reviewed changes

Update tools/rpctypegen/Cargo.toml

18ccdf3

Co-Authored-By: Maksym Zavershynskyi <[email protected]>

MaksymZavershynskyi mentioned this pull request Jan 20, 2020

ActionError::FunctionCallError is a free form string #1731

Closed

lexfrl added 5 commits January 20, 2020 15:50

removed rpc_error_variant attribute

361319b

split rpctypegen into core and macro crated + tests added

7bbba23

Merge branch 'staging' into fckt/rpc-errors

615121d

ServerError Display impl

addf11f

moved build_errors_schema.sh and res/rpc_errors_schema.json to a json…

c1a094b

…-rpc crate

lexfrl requested a review from MaksymZavershynskyi January 20, 2020 22:35

MaksymZavershynskyi assigned lexfrl Jan 21, 2020

lexfrl added 2 commits January 21, 2020 16:47

fix rpc-errors test

d9f3c6d

ActionError -> RequiresFullAccess

e44e157

evgenykuzyakov reviewed Jan 21, 2020

View reviewed changes

core/primitives/src/errors.rs Outdated Show resolved Hide resolved

evgenykuzyakov approved these changes Jan 21, 2020

View reviewed changes

Merge branch 'staging' into fckt/rpc-errors

d56236f

lexfrl added the automerge label Jan 22, 2020

fix comment

983478b

Co-Authored-By: Evgeny Kuzyakov <[email protected]>

MaksymZavershynskyi approved these changes Jan 22, 2020

View reviewed changes

nearprotocol-bulldozer bot merged commit da9e48b into staging Jan 22, 2020

nearprotocol-bulldozer bot deleted the fckt/rpc-errors branch January 22, 2020 16:59

weekly-digest bot mentioned this pull request Jan 24, 2020

Weekly Digest (17 January, 2020 - 24 January, 2020) #2018

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Error messages refactoring #1854

Error messages refactoring #1854

lexfrl commented Dec 12, 2019 •

edited

Loading

MaksymZavershynskyi left a comment

MaksymZavershynskyi Dec 20, 2019

bowenwang1996 Dec 20, 2019

MaksymZavershynskyi Dec 20, 2019

bowenwang1996 Dec 20, 2019

MaksymZavershynskyi Dec 20, 2019

frol Dec 21, 2019

lexfrl commented Dec 20, 2019

lexfrl commented Dec 23, 2019 •

edited

Loading

MaksymZavershynskyi left a comment

MaksymZavershynskyi Jan 17, 2020

lexfrl Jan 20, 2020

MaksymZavershynskyi Jan 20, 2020

lexfrl Jan 20, 2020 •

edited

Loading

evgenykuzyakov left a comment

evgenykuzyakov Jan 21, 2020

lexfrl Jan 22, 2020

MaksymZavershynskyi commented Jan 22, 2020

lexfrl commented Jan 22, 2020

Error messages refactoring #1854

Error messages refactoring #1854

Conversation

lexfrl commented Dec 12, 2019 • edited Loading

MaksymZavershynskyi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lexfrl commented Dec 20, 2019

lexfrl commented Dec 23, 2019 • edited Loading

MaksymZavershynskyi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lexfrl Jan 20, 2020 • edited Loading

Choose a reason for hiding this comment

evgenykuzyakov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MaksymZavershynskyi commented Jan 22, 2020

lexfrl commented Jan 22, 2020

lexfrl commented Dec 12, 2019 •

edited

Loading

lexfrl commented Dec 23, 2019 •

edited

Loading

lexfrl Jan 20, 2020 •

edited

Loading