Skip to content

feat: emit completion events#3

Merged
andrey-canon merged 1 commit intoopen-release/redwood.nelpfrom
redwood-mig/add_completion_events
Dec 12, 2024
Merged

feat: emit completion events#3
andrey-canon merged 1 commit intoopen-release/redwood.nelpfrom
redwood-mig/add_completion_events

Conversation

@andrey-canon
Copy link
Collaborator

@andrey-canon andrey-canon commented Dec 11, 2024

Description

Migration pr of #1, most of the changes were included into the upstream version, however the completion events were not included, this adds that support issue

How to test

  1. Create a section with one subsection and one unit
  2. Completes previous unit
  3. check that chapter, sequential and vertical events was emitted

image

@andrey-canon andrey-canon force-pushed the redwood-mig/add_completion_events branch from 3684aca to e332cbd Compare December 11, 2024 20:43
Copy link

@johanseto johanseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working in my local env

Screenshot from 2024-12-12 09-58-11
Screenshot from 2024-12-12 09-57-41

@andrey-canon andrey-canon merged commit 428cded into open-release/redwood.nelp Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants