Skip to content

feat: emit completion events #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrey-canon merged 1 commit into from
Dec 12, 2024
Merged

feat: emit completion events #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,4 @@ jobs:
with:
token: ${{ secrets.CODECOV_TOKEN }}
flags: unittests
fail_ci_if_error: true
fail_ci_if_error: false
3 changes: 2 additions & 1 deletion completion_aggregator/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,12 +190,13 @@ def emit_completion_aggregator_logs(updated_aggregators):
return

for aggregator in updated_aggregators:
event = "progress" if aggregator.percent < 1 else "completion"
block_type = aggregator.aggregation_name

if block_type not in settings.COMPLETION_AGGREGATOR_TRACKING_EVENT_TYPES:
continue

event_name = f"openedx.completion_aggregator.progress.{block_type}"
event_name = f"openedx.completion_aggregator.{event}.{block_type}"

tracker.emit(
event_name,
Expand Down