Revised module suitable for new NESTExtensionModule interface#26
Revised module suitable for new NESTExtensionModule interface#26terhorstd merged 12 commits intonest:masterfrom
Conversation
|
Even while the example module still needs a lot of polishing, this one should be reviewed and merged soon so we have one that works with the new NEST mechanism. Then we also need to think about versioning these modules, we need releases that fit the NEST releases. |
terhorstd
left a comment
terhorstd
left a comment
There was a problem hiding this comment.
Good suggestion to switch to mynest namespace.
Some small points
|
Actions need to be re-run when nest/nest-simulator#3103 is merged. |
pnbabu
left a comment
pnbabu
left a comment
There was a problem hiding this comment.
I have one minor comment.
Also, what did we decide on the TODOs in the CMakeLists.txt file? Shall we remove them now and create an issue to address it later?
|
@heplesser ping! |
|
@terhorstd @pnbabu I have now addressed your comments, I hope to your content. |
Co-authored-by: Dennis Terhorst <terhorstd@users.noreply.github.com>
pnbabu
left a comment
pnbabu
left a comment
There was a problem hiding this comment.
It looks good to me overall. I am fine with merging this after fixing the failing build on macOS.
I have now hiked the Python version to 3.12, so building should work again on macOS. |
|
But now the Linux build failed with what looks like a problem not related to our code. Strangely, I do not find a re-run button for actions in this repo. Let's see how it goes with the macOS build. |
Perhaps it's the access issue? I could see the button and the job is running again now. |
terhorstd
left a comment
terhorstd
left a comment
There was a problem hiding this comment.
At some point we will have a discussion about the Python versions again, but that's a different story and will be told in another PR.
Thanks for all the effort!
3 participants
This is the first example (in draft state) of the new
NESTExtensionInterfaceandModuleManagerapproach to handling modules.